Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make pass/fail match grades #117

Closed
bmtcril opened this issue Jul 29, 2024 · 5 comments · Fixed by openedx/aspects-dbt#138
Closed

Make pass/fail match grades #117

bmtcril opened this issue Jul 29, 2024 · 5 comments · Fixed by openedx/aspects-dbt#138
Assignees

Comments

@bmtcril
Copy link
Contributor

bmtcril commented Jul 29, 2024

Currently the pass/fail state of a user is randomly generated, as are the current grades. This creates confusing visuals where the number of passing students is completely divorced from their grades. We should tie those events together to make visualizations less confusing.

@saraburns1
Copy link
Contributor

course_grade comes from any grading events where the object_id has 'course'
approving_state comes from only passed/failed events

so even outside of load xapi data, the pass/fail status doesn't necessarily line up with the grade (ie, there could be an earned event without a passed event)

@saraburns1
Copy link
Contributor

To help with this, we will use the 'earned' events grade classification in combination with the passed/failed verbs

Passed/failed verb events do NOT have a score associated with them so there is still a possibility of a learner with 'passed' status and '0' score

@bmtcril
Copy link
Contributor Author

bmtcril commented Jan 14, 2025

Yeah, part of this issue is that what constitutes a passing grade is configurable per course (and so can change over time), so we count on the LMS to just tell us when a student is passing / failing.

@saraburns1
Copy link
Contributor

If we use the grade_classification from the earned events, though, that should be accurate right?

@bmtcril
Copy link
Contributor Author

bmtcril commented Jan 15, 2025

Just to write down what we discussed, I think that's correct as long as we're only looking at the course level events.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

2 participants