Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add reserved keywords linter #166

Merged
merged 7 commits into from
Jan 12, 2024
Merged

chore: add reserved keywords linter #166

merged 7 commits into from
Jan 12, 2024

Conversation

arbabkhalil
Copy link
Contributor

Description:

Check reserved keywords in CI

JIRA:

PSRE-1253

Additional Details

  • Dependencies:: List dependencies on other outstanding PRs, issues, etc.
  • Merge deadline: List merge deadline (if any)
  • Testing instructions: Provide non-trivial testing instructions
  • Author concerns: List any concerns about this PR

Reviewers:

  • tag reviewer

Merge checklist:

  • All reviewers approved
  • CI build is green
  • Version bump if needed
  • Changelog record added
  • Documentation updated (not only docstrings)
  • Commits are squashed

Post merge:

  • Create a tag
  • Check new version is pushed to PyPi after tag-triggered build is
    finished.
  • Delete working branch (if not needed anymore)

@rgraber
Copy link
Contributor

rgraber commented Jan 9, 2024

Hi @arbabkhalil ! Should this PR be updated and reviewed or discarded? We're cleaning out old open PRs and this one has not been touched for 2 years.

@rgraber
Copy link
Contributor

rgraber commented Jan 12, 2024

We've got the go-ahead from SRE and data engineering to merge all these but this one appears to have errors.

@rgraber rgraber merged commit ad26c15 into master Jan 12, 2024
6 checks passed
@rgraber rgraber deleted the arbabkhalil/PSRE-1253 branch January 12, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants