Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discovery: What is the process to get a new language supported on an MFE? #479

Closed
Tracked by #688 ...
jmakowski1123 opened this issue Sep 30, 2022 · 6 comments
Closed
Tracked by #688 ...
Assignees

Comments

@jmakowski1123
Copy link

jmakowski1123 commented Sep 30, 2022

Put simply, find out how add a language (say, Esperanto) to MFEs. This includes:

  • The learner being able to select it from somewhere (find out where)
  • The deployer should be able to select it for inclusion in their instance
  • The translator should be able to select that language for translation
  • It should be possible to pull the translated strings back into the several components of the platform

Document this via openedx/docs.openedx.org#154

@brian-smith-tcril
Copy link

document current process:
seems it's just (basing this on https://github.com/openedx/frontend-app-learning/blob/master/Makefile)
for each MFE

  • make extract_translations
  • make push_translations
  • make pull_translations

automate extract process

@arbrandes arbrandes changed the title Discovery: What is the process to get a new language supported on edx-platform? In the MFEs? Discovery: What is the process to get a new language supported on an MFE? Nov 3, 2022
@brian-smith-tcril
Copy link

adding a new language

using https://github.com/openedx/frontend-app-library-authoring as an example:

update https://github.com/openedx/frontend-app-library-authoring/blob/88a4502b12269bbb4cb548eb6ce9bb840ba6b975/Makefile#L2 to have the new lang

??? do something in transifex ???

extract translation files

make extract_translations

get source strings into transifex

install transifex cli https://developers.transifex.com/docs/cli

??? do something with detect_changed_source_translations ???

make push_translations

get translations back into repo

make pull_translations

how much of this is automated?

not sure yet

@brian-smith-tcril
Copy link

based on the commit message on openedx/openedx-translations@33b6cd2

going forward we'll want to use https://github.com/openedx/openedx-translations/blob/main/transifex.yml instead of the transifex cli

@brian-smith-tcril
Copy link

looks like pulling down updated translations is automated (see openedx/frontend-app-account#655), i'm not sure where this is being run from or where the code for it lives, my assumption is it's just running make pull_translations on each MFE but without seeing the code i cannot confirm

@arbrandes arbrandes moved this from In progress to In review in Frontend Working Group Nov 14, 2022
@arbrandes arbrandes moved this from To Do - Backlog to In Progress in Axim Engineering Tasks Nov 30, 2022
@arbrandes arbrandes self-assigned this Nov 30, 2022
@arbrandes
Copy link
Contributor

Going to finally give this a proper review this sprint. Apologies for the delay, @brian-smith-tcril!

@arbrandes
Copy link
Contributor

Atlas migration is in full swing, so we can close this!

@github-project-automation github-project-automation bot moved this from In review to Closed in Frontend Working Group Mar 6, 2024
@github-project-automation github-project-automation bot moved this from To Do to Done in Axim Engineering Tasks Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Status: Closed
Development

No branches or pull requests

3 participants