Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: prerequisite for RUM #2486

Merged
merged 2 commits into from
May 22, 2024

Conversation

deborahgu
Copy link
Member

@deborahgu deborahgu commented May 22, 2024

This updates edx-django-utils to the newest version, which will enable us to enable RUM in program certs once @iamsobanjaved's work in https://github.com/edx/edx-internal/pull/10902 is complete.

(note we don't actually have to wait for that other PR to deploy credentials)

FIXES: APER-3470

Run JavaScript tests locally with Karma

There is work being done on a fix to get Karma to run in CI. Until then, however, contributors are required to run these tests locally.

  • Make sure you are inside the devstack container
  • Run make test-karma
  • All tests pass

This updates edx-django-utils to the newest version, which will enable
us to enable RUM in program certs once @iamsobanjaved's work in
edx/edx-internal#10902 is complete.

FIXES: APER-3470
@deborahgu deborahgu requested a review from a team as a code owner May 22, 2024 16:14
@iamsobanjaved
Copy link
Contributor

There was an issue in that release caught during tests run in the edx-platform, created a fix PR and will release the package once tests with this PR's hash are green in the edx-platform

openedx/edx-django-utils#416

@deborahgu
Copy link
Member Author

thanks!

Updating to the newer version of utils.

FIXES: APER-3470
@deborahgu deborahgu merged commit 5f45ade into master May 22, 2024
11 checks passed
@deborahgu deborahgu deleted the dkaplan1/APER-3470_add-rum-to-program-certificates branch May 22, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants