doc: Update Developer Guide (contributing information) #395
Conversation
sarina
force-pushed
the
sarina/contributors
branch
from
d5fd6a5 to
10fcd4e
Compare
sarina
changed the title
|
@mphilbrick211 - can you review? You can view the rendered page here: https://docsopenedxorg--395.org.readthedocs.build/en/395/developers/references/developer_guide/process/FAQ-about-pull-requests.html |
| @@ -0,0 +1,167 @@ | |||
| ###################################################### | |||
There was a problem hiding this comment.
This is a new file, written by Michelle and Tim, and reviewed/transcribed by me.
sarina
force-pushed
the
sarina/contributors
branch
from
22ea93a to
0b51367
Compare
|
@sarina - Looks great! I also shared this with you: https://docs.google.com/document/d/1mDBCUqAveG1LFDgmU3CodaeYWJYITiBtFEWc29sEL5Q/edit#heading=h.wvrelfg3igbm |
source/developers/references/developer_guide/process/FAQ-about-pull-requests.rst
Show resolved
Hide resolved
source/developers/references/developer_guide/process/pull-request-statuses.rst
Show resolved
Hide resolved
docs: Remove outdated pr-process diagram
sarina
force-pushed
the
sarina/contributors
branch
from
1b3f51c to
0881914
Compare
| of the pull request. | ||
| * - .. image:: /_images/pr_label_inactive.png | ||
| - Used when the author has been unresponsive for an extended period of | ||
| time. The Community Projects Managers will typically give a final comment |
There was a problem hiding this comment.
| time. The Community Projects Managers will typically give a final comment | |
| time. The Community Project Managers will typically give a final comment |
| There may be times where a pull request is closed (instead of merged) by an | ||
| owning team because the update may no longer be needed, it's duplicative of | ||
| other work, or other reasons. The reason for closing the pull request should be |
There was a problem hiding this comment.
@sarina That reminds me -- I think the "duplicate" label is missing from the section on Contribution Board Labels.
There was a problem hiding this comment.
Can you provide a description for "duplicate"?
I used the one from the label on GitHub - "This issue or pull request already exists elsewhere."
sarina
added
duplicate
|
@itsjeyd can you please provide a final review? |
|
@sarina I checked the changes that you pushed to address my earlier comments. They look good to me. If you'd like me to do a full pass before approving, please let me know so I can allocate time for it in the next OpenCraft sprint (starting Tuesday). |
|
@itsjeyd i'm going to go ahead and merge. We should use these pages as references and make further updates as needed. |
|
@sarina Sounds good 👍 |
No description provided.