Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AdjustingFindingaStringToTranslate.rst #426

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Conversation

jesgreco
Copy link
Contributor

@jesgreco jesgreco commented Nov 9, 2023

Adjusting bold type in 2 steps within "Finding a string to translate" section and adjusting the numbered list to avoid duplicates (two number 1, steps 1 & 2).

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 9, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @jesgreco! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

Adjusting bold type in 2 steps within "Finding a string to translate"
section and adjusting the numbered list to avoid duplicates (two number
1, steps 1 & 2).
@@ -53,7 +53,7 @@ Finding a string to translate
#. Once you have joined the edx-platform project, you will be able to select the option
"Languages" from the left hand menu under "edx-platform"

.. image:: /_images/SelectLanguages.png
.. image:: /_images/SelectLanguages.png
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, you don't need to manually number the items but the numbers were being thrown off because this image was not properly indented. If it doesn't align with the beginning of the paragraph above it. RST thinks you are starting a new item and so it re-started the counting.

@feanil feanil merged commit 72a3e90 into openedx:main Nov 13, 2023
@openedx-webhooks
Copy link

@jesgreco 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants