-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Open edX support doc for enabling waffle flags #454
Conversation
Thanks for the pull request, @jimjohnson8! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. Once you've signed the CLA, please allow 1 business day for it to be processed. After this time, you can re-run the CLA check by adding a comment here that you have signed it. If the problem persists, you can tag the |
Hi @jimjohnson8! Thanks for this contribution! Please let me know if you have any questions regarding submitting a CLA form. |
Thanks! I'll get that filled out today. |
Hi @jimjohnson8 - were you able to submit your CLA form? If you re-run the tests, the CLA check should turn green if it's all set. |
Hi @jimjohnson8! Just following up on this. |
Hi @jimjohnson8! Just checking in to see if you plan to pursue this PR. If not, we can close it for now and reopen in the future. |
@mphilbrick211 - judging by @jimjohnson8 's LinkedIn from their GitHub profile, they were working at 2U when they made this contribution but no longer do. If we can confirm they were covered by 2U's CLA at the time of this submission, I can take over the PR and get it merged. I'll send an email to see if we can get this cleared up. |
@sarina - did we ever hear back on this? |
I was at 2U when I made this change. |
I was laid off not long after this change was pushed up. |
Thanks for the detail, @jimjohnson8 ! I will need to confirm it with someone who works at 2U, so I will bump that email thread. |
Hi all, I have confirmation from George at 2U that Jim was under 2U's CLA when this pull request was made. I have some changes I'll be making to the PR and then I will merge. |
@jimjohnson8 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
For TNL-11198, the Open edX docs need to contain a page on how to enable a waffle flag for a user. Private details from this doc have been removed.