Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Open edX support doc for enabling waffle flags #454

Merged
merged 2 commits into from
May 1, 2024
Merged

Add Open edX support doc for enabling waffle flags #454

merged 2 commits into from
May 1, 2024

Conversation

cerberus6106
Copy link
Contributor

For TNL-11198, the Open edX docs need to contain a page on how to enable a waffle flag for a user. Private details from this doc have been removed.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jan 9, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @jimjohnson8! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

⚠️ We can't start reviewing your pull request until you've submitted a signed contributor agreement or indicated your institutional affiliation. Please see the CONTRIBUTING file for more information. If you've signed an agreement in the past, you may need to re-sign. See The New Home of the Open edX Codebase for details.

Once you've signed the CLA, please allow 1 business day for it to be processed. After this time, you can re-run the CLA check by adding a comment here that you have signed it. If the problem persists, you can tag the @openedx/cla-problems team in a comment on your PR for further assistance.

@mphilbrick211
Copy link

Hi @jimjohnson8! Thanks for this contribution! Please let me know if you have any questions regarding submitting a CLA form.

@cerberus6106
Copy link
Contributor Author

Thanks! I'll get that filled out today.

@mphilbrick211
Copy link

mphilbrick211 commented Jan 16, 2024

Hi @jimjohnson8 - were you able to submit your CLA form? If you re-run the tests, the CLA check should turn green if it's all set.

@mphilbrick211
Copy link

Hi @jimjohnson8 - were you able to submit your CLA form? If you re-run the tests, the CLA check should turn green if it's all set.

Hi @jimjohnson8! Just following up on this.

@mphilbrick211
Copy link

Hi @jimjohnson8! Just checking in to see if you plan to pursue this PR. If not, we can close it for now and reopen in the future.

@mphilbrick211 mphilbrick211 added the inactive PR author has been unresponsive for several months label Mar 20, 2024
@sarina
Copy link
Contributor

sarina commented Mar 25, 2024

@mphilbrick211 - judging by @jimjohnson8 's LinkedIn from their GitHub profile, they were working at 2U when they made this contribution but no longer do. If we can confirm they were covered by 2U's CLA at the time of this submission, I can take over the PR and get it merged. I'll send an email to see if we can get this cleared up.

@mphilbrick211
Copy link

@mphilbrick211 - judging by @jimjohnson8 's LinkedIn from their GitHub profile, they were working at 2U when they made this contribution but no longer do. If we can confirm they were covered by 2U's CLA at the time of this submission, I can take over the PR and get it merged. I'll send an email to see if we can get this cleared up.

@sarina - did we ever hear back on this?

@cerberus6106
Copy link
Contributor Author

I was at 2U when I made this change.

@cerberus6106
Copy link
Contributor Author

I was laid off not long after this change was pushed up.

@sarina
Copy link
Contributor

sarina commented May 1, 2024

Thanks for the detail, @jimjohnson8 ! I will need to confirm it with someone who works at 2U, so I will bump that email thread.

@sarina
Copy link
Contributor

sarina commented May 1, 2024

Hi all,

I have confirmation from George at 2U that Jim was under 2U's CLA when this pull request was made. I have some changes I'll be making to the PR and then I will merge.

@sarina sarina self-assigned this May 1, 2024
@sarina sarina merged commit df23481 into openedx:main May 1, 2024
1 of 2 checks passed
@openedx-webhooks
Copy link

@jimjohnson8 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
inactive PR author has been unresponsive for several months open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants