Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Remove references to the Insights product #489

Merged
merged 3 commits into from
May 2, 2024

Conversation

bmtcril
Copy link
Contributor

@bmtcril bmtcril commented May 1, 2024

Historical data in release notes has been left.

Copy link
Contributor

@sarina sarina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, a couple comments that you may consider out of scope.

Question: The changes are agnostic to any "reporting and analytics system", which makes sense to me, but is there existing or planned documentation to highlight what such system(s) are available?

Historical data in release notes has been left.
@bmtcril bmtcril force-pushed the bmtcril/update_for_insights_depr branch from dc12680 to beb320b Compare May 1, 2024 23:33
@bmtcril
Copy link
Contributor Author

bmtcril commented May 1, 2024

@sarina I don't know of any high level documentation about analytics options in this repo, but we do have a big pile of docs coming as part of the Aspects FC so I'll make sure we add pointers to existing systems where it makes sense.

@sarina
Copy link
Contributor

sarina commented May 1, 2024

@bmtcril sounds excellent. I'm sure it'll be an iterative process of improving! Off to a great start. From my perspective you're good to merge when you're satisfied.

@bmtcril bmtcril merged commit ec74278 into main May 2, 2024
2 checks passed
@bmtcril bmtcril deleted the bmtcril/update_for_insights_depr branch May 2, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants