Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FC-0068 docs: update quick reference RST content #613

Merged
merged 2 commits into from
Nov 25, 2024

Conversation

Apgomeznext
Copy link
Contributor

This PR adds the references from the past Templates page to the quick reference RST page to avoid losing import information while adding the new content.

This PR adds the references from the past Templates page to the quick reference RST page to avoid losing import information while adding the new content.
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 18, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Nov 18, 2024

Thanks for the pull request, @Apgomeznext!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/docs-openedx-org-maintainers. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@Apgomeznext Apgomeznext marked this pull request as ready for review November 18, 2024 17:41
@Apgomeznext Apgomeznext self-assigned this Nov 18, 2024
@@ -19,6 +19,55 @@ Headings

RST allows you to use almost any symbol to underline headings, as long as you're consistent between heading level. However, the way shown above is how headings should be defined in all Open edX documentation.

Develop Sections
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Develop Sections
How To Use Sections Effectively


You can nest sections in the topic as needed, to give it structure and break it up into discrete parts.

Copy the Topic and Section Structure as needed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Copy the Topic and Section Structure as needed
Copy the Topic and Section Structure below as needed.

If this is a long topic with multiple sections, use the **contents** directive below:

.. contents:: Contents
:local:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is indented wrong I think, the : needs to be two spaces in from the above ... I'd also add the :depth: parameter.

.. contents::
  :depth: 1
  :local:

@@ -172,6 +221,111 @@ Use the following code:

.. seealso:: To see alternative ways of defining tables, visit the `RST documentation about this topic <https://canonical-documentation-with-sphinx-and-readthedocscom.readthedocs-hosted.com/style-guide/#tables>`_.

Add a Substitution
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this section is more confusing than helpful. I've never used this - do we use it a lot?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have never used it either. I added it because it was on the previous template page, and I wanted to include all the content in case it was necessary.
If you agree, I will erase it for the final version.

Add a Sidebar
*************

You can add any content in a sidebar. Open edX uses sidebars for image thumbnails, videos, and other notes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
You can add any content in a sidebar. Open edX uses sidebars for image thumbnails, videos, and other notes.
You can add any content in a sidebar. Open edX documentation uses sidebars for image thumbnails, videos, and other notes.

Use Open edX as an adjective. Also, the site already has sidebars, should we be encouraging use of more?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is the same case as the substitution. I added it here to keep all the information on the previous template page. Still, I agree with you that adding more sidebars to the repository can be excessive, as we already have it. However, in the case of parallel repositories like the one for Aspects, it could be helpful to have different tools and references.
I have also seen these sidebars used in glossaries. I vote to keep it.


A line of text with an |variable name| inserted.

Add an Thumbnail in a Sidebar
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Add an Thumbnail in a Sidebar
Add a Thumbnail in a Sidebar


.. thumbnail:: _images/image-file-name

Use Inline Formatting
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mphilbrick211 mphilbrick211 added the FC Relates to an Axim Funded Contribution project label Nov 21, 2024
This PR solves Sarina's change request.
@sarina sarina merged commit 81414a2 into openedx:main Nov 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FC Relates to an Axim Funded Contribution project open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants