-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: adjusting for cleanup reference docs #625
Conversation
Thanks for the pull request, @jesgreco! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know what the two empty tables are for.
source/educators/references/grading/gradebook_assignment_types.rst
Outdated
Show resolved
Hide resolved
@jesgreco This is happening because when you change a reference to an external link, you've got to update the corresponding links.txt (or links.rst, I forget if it could be both) or else you will get build errors. And it isn't as simple as just changing something like partners.edx.org to partners.openedx.org. In almost all cases, Open edX won't have corresponding links for things that exist on edx.org. So you've got to make a determination if we can replace the link with something that has similar purpose for Open edX. If not, then you've got to decide how you can remove the reference. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR contains changes from #615. Pull requests should only contain one set of changes. I will review this when this doesn't contain the style guide.
3599068
to
7745559
Compare
fixing cleanup ref for resources_for_course_teams fixing external links cleaning up for enrollment_requirements.rst and message_text.rst cleaning up for scheduling_course.rst cleaning up for resources_for_open_edx.rst docs: cleanup for course_pacing.rst docs: adjusting error tables docs: cleanup for resources_for_course_teams docs: cleanup for roles_for_viewing.rst docs: cleanup for gradebook_assignment_types.rst docs: adjusting reference docs learner_view_of_grades doc being cleaned up.
7745559
to
27a0761
Compare
I've just reviewed this PR and it ok to be merged. @sarina let me know if you are ok :) |
source/educators/references/student_management/enrollment_requirements.rst
Outdated
Show resolved
Hide resolved
source/educators/references/student_management/enrollment_requirements.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: Sarina Canelake <[email protected]>
Co-authored-by: Sarina Canelake <[email protected]>
…irements.rst Co-authored-by: Sarina Canelake <[email protected]>
…sneo/docs.openedx.org into jesgreco/cleanup_references
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sarina I've just finished with all your comments!
@sarina all changes are done! |
This doc learner_view_of_grades.rst is being cleaned up: https://docs.openedx.org/en/latest/educators/references/grading/learner_view_of_grades.html