-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup for howtos3 #638
cleanup for howtos3 #638
Conversation
cleaning up drag_and_drop_deprecated.rst doc
Thanks for the pull request, @jesgreco! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
@sarina you can proceed to the merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My comments are addressed, but I asked @jswope00 to review this PR as well. John can merge once his review is completed. (John, I suggest you "squash and merge" so we don't have a really long commit history)
ok, @sarina - I've added one more file since one of it was deleted (the deprecated one). |
@@ -251,7 +251,7 @@ The gradebook includes the following features: | |||
specific graded subsection. For information about how to do this, see | |||
:ref:`Override in Gradebook`. | |||
|
|||
* **Master’s courses:** The edX gradebook has several features for high-touch courses. For learners in the Master’s track: | |||
* **Master’s courses:** The Open edX gradebook has several features for high-touch courses. For learners in the Master’s track: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agree that references to "Master's courses" should be removed.
@jswope00 I've just finished with your comments, you can proceed to merge the PR. |
@jesgreco please do not add more stuff to a branch after the review has happened! |
Hi, @sarina I only work on the stuff asked by John. Sorry, but there were some conflicts also that needed to be solved. |
Ah, it looked like you were pushing unrelated commits. Thank you.
…On Thu, Dec 19, 2024 at 1:22 PM jesgreco ***@***.***> wrote:
Hi, @sarina <https://github.com/sarina> I only work on the stuff asked by
John. Sorry, but there were some conflicts also that needed to be solved.
—
Reply to this email directly, view it on GitHub
<#638 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAPEWJPPQXOHLZMLARCMZLD2GMFIBAVCNFSM6AAAAABTFDCXSCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNJVGUYDCNJZHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
cleaning up drag_and_drop_deprecated.rst doc