Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Aspects Course Comparison Dashboard feature release notes #642

Merged
merged 6 commits into from
Dec 10, 2024

Conversation

crathbun428
Copy link
Contributor

Updated feature release notes, added image files, fixed inline links.

Expand Aspects Course Comparison Dashboard feature release notes.
Add image files for Aspects Course Comparison Dashboard feature release notes
@crathbun428 crathbun428 requested a review from sarina December 10, 2024 15:57
The Course Comparison Dashboard makes it easy to identify courses with the highest and lowest levels of enrollment and activity with tables that allow users to sort courses or runs by current enrollment or active learner count.

.. image:: /_images/sumac-aspects-course-info-2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to put .png at the end of these filenames! (full file names, not just title). Also the path to the folder is wrong.

Suggested change
.. image:: /_images/sumac-aspects-course-info-2
.. image:: /_images/release_notes/sumac/sumac-aspects-course-info-2.png

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be sure to fix all the filenames in this doc please :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah - yikes. Will do.

@crathbun428
Copy link
Contributor Author

@sarina - OK - I added 2 commits to this branch - do I need to create a new pull request or are these captured? (I see them above, so I'd assume not?).

@sarina
Copy link
Contributor

sarina commented Dec 10, 2024

Looks good to me! Check out the rendered view (https://docsopenedxorg--642.org.readthedocs.build/en/642/community/release_notes/sumac/aspects_comp_dashboard.html) to make sure you're happy with it, and I'll merge.

Added a between final image and final paragraph
@crathbun428
Copy link
Contributor Author

@sarina - thank you for your review. I added one return between the final picture and final paragraph. Rest looks good to me.

@sarina sarina enabled auto-merge (rebase) December 10, 2024 18:27
@sarina sarina merged commit 192cfcd into openedx:main Dec 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants