-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Aspects Course Comparison Dashboard feature release notes #642
Conversation
Expand Aspects Course Comparison Dashboard feature release notes.
Add image files for Aspects Course Comparison Dashboard feature release notes
The Course Comparison Dashboard makes it easy to identify courses with the highest and lowest levels of enrollment and activity with tables that allow users to sort courses or runs by current enrollment or active learner count. | ||
|
||
.. image:: /_images/sumac-aspects-course-info-2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have to put .png
at the end of these filenames! (full file names, not just title). Also the path to the folder is wrong.
.. image:: /_images/sumac-aspects-course-info-2 | |
.. image:: /_images/release_notes/sumac/sumac-aspects-course-info-2.png |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Be sure to fix all the filenames in this doc please :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah - yikes. Will do.
@sarina - OK - I added 2 commits to this branch - do I need to create a new pull request or are these captured? (I see them above, so I'd assume not?). |
Looks good to me! Check out the rendered view (https://docsopenedxorg--642.org.readthedocs.build/en/642/community/release_notes/sumac/aspects_comp_dashboard.html) to make sure you're happy with it, and I'll merge. |
Added a between final image and final paragraph
@sarina - thank you for your review. I added one return between the final picture and final paragraph. Rest looks good to me. |
Updated feature release notes, added image files, fixed inline links.