Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FC-0068 docs: concept cleaning by edunext #11 #716

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

BryanttV
Copy link
Contributor

This PR modifies a series of concept documents migrated from the legacy repositories to the educators' documentation.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Dec 31, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Dec 31, 2024

Thanks for the pull request, @BryanttV!

This repository is currently maintained by @openedx/docs-openedx-org-maintainers.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@BryanttV BryanttV force-pushed the bav/educators_documentation_review_edunext_12 branch from 4099749 to 6d08a6c Compare December 31, 2024 16:42
@BryanttV BryanttV changed the title FC-0068 docs: Concept cleaning by edunext #11 FC-0068 docs: concept cleaning by edunext #11 Dec 31, 2024
@BryanttV BryanttV force-pushed the bav/educators_documentation_review_edunext_12 branch from 6d08a6c to 1a9439b Compare December 31, 2024 18:51
@mphilbrick211 mphilbrick211 added the FC Relates to an Axim Funded Contribution project label Jan 2, 2025
@sarina
Copy link
Contributor

sarina commented Jan 6, 2025

@BryanttV is this ready for review?

@BryanttV
Copy link
Contributor Author

BryanttV commented Jan 7, 2025

Hi @sarina, yeah, this is ready. Thanks!

@BryanttV BryanttV requested a review from sarina January 7, 2025 19:11
Copy link
Contributor

@sarina sarina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only reviewed the first file. Please take a look through my comments, and update following documents appropriately before requesting a re-review. Particularly, "Open edX" should be used as an adjective, should not be capitalized as "Open Edx", and some judgement should be applied when to use something like "your Open edX instance" or simply "your instance".

@BryanttV BryanttV force-pushed the bav/educators_documentation_review_edunext_12 branch from f7fe914 to 9eac14c Compare January 8, 2025 22:43
@BryanttV BryanttV force-pushed the bav/educators_documentation_review_edunext_12 branch from d88c241 to 1d2621d Compare January 9, 2025 16:28
@BryanttV BryanttV requested review from Apgomeznext and sarina January 9, 2025 18:04
@BryanttV BryanttV requested a review from sarina January 10, 2025 17:59
@sarina
Copy link
Contributor

sarina commented Jan 13, 2025

@BryanttV - there are conflicts in this PR - please resolve and ping me for merge.

@BryanttV BryanttV force-pushed the bav/educators_documentation_review_edunext_12 branch from 72a1b1d to d0069bc Compare January 14, 2025 14:44
@BryanttV
Copy link
Contributor Author

Thanks @sarina!, I resolved the conflicts, the PR is ready to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FC Relates to an Axim Funded Contribution project open-source-contribution PR author is not from Axim or 2U
Projects
Status: Ready for Review
Development

Successfully merging this pull request may close these issues.

5 participants