Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add support for ora mfe url #2126

Merged
merged 1 commit into from
Nov 27, 2023
Merged

chore: add support for ora mfe url #2126

merged 1 commit into from
Nov 27, 2023

Conversation

leangseu-edx
Copy link
Contributor

TL;DR - add ORA_MICROFRONTEND_URL support

https://2u-internal.atlassian.net/browse/AU-1571

NOTE: this pr will be merge after along with openedx/edx-platform#33809

What changed?

  • the setting will be set on edx-platform env

Developer Checklist

Reviewer Checklist

Collectively, these should be completed by reviewers of this PR:

  • I've done a visual code review
  • I've tested the new functionality

FYI: @openedx/content-aurora

@leangseu-edx leangseu-edx requested a review from a team as a code owner November 27, 2023 21:17
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8040408) 95.01% compared to head (11daa5c) 95.01%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2126   +/-   ##
=======================================
  Coverage   95.01%   95.01%           
=======================================
  Files         191      191           
  Lines       20537    20537           
  Branches     1860     1860           
=======================================
  Hits        19513    19513           
  Misses        767      767           
  Partials      257      257           
Flag Coverage Δ
unittests 95.01% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leangseu-edx leangseu-edx merged commit 6dcdc3c into master Nov 27, 2023
7 checks passed
@leangseu-edx leangseu-edx deleted the lk/add-ora-mfe-url branch November 27, 2023 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants