Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make loading a bit more appealing #2139

Closed
wants to merge 1 commit into from

Conversation

leangseu-edx
Copy link
Contributor

@leangseu-edx leangseu-edx commented Dec 12, 2023

image

What changed?

  • [ More in depth breakdown of changes ]

Developer Checklist

Testing Instructions

[ How should a reviewer test this PR? ]

Reviewer Checklist

Collectively, these should be completed by reviewers of this PR:

  • I've done a visual code review
  • I've tested the new functionality

FYI: @openedx/content-aurora

@leangseu-edx leangseu-edx requested a review from a team as a code owner December 12, 2023 18:03
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d88d1a7) 94.94% compared to head (483772f) 94.94%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2139   +/-   ##
=======================================
  Coverage   94.94%   94.94%           
=======================================
  Files         191      191           
  Lines       20515    20515           
  Branches     1858     1858           
=======================================
  Hits        19478    19478           
  Misses        777      777           
  Partials      260      260           
Flag Coverage Δ
unittests 94.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leangseu-edx leangseu-edx deleted the lk/ora-mfe-loading branch January 22, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant