Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update autogenerated username functionality #35052

Merged

Conversation

attiyaIshaque
Copy link
Contributor

@attiyaIshaque attiyaIshaque commented Jul 1, 2024

Description

"When entering special characters like '=', '@', or any other, it raised a server error when the autogenerated username was enabled. I have fixed it in the backend, and now users are allowed to create accounts with special characters."
Useful information to include:

JIRA:

https://2u-internal.atlassian.net/browse/VAN-1988

How Has This Been Tested?

Updated unit tests

Video :

Untitled.mov

@attiyaIshaque attiyaIshaque force-pushed the attiya/VAN-1988-auto-generated_username-update branch from 1b7d81c to 54d8ec5 Compare July 2, 2024 07:35
@attiyaIshaque attiyaIshaque marked this pull request as ready for review July 2, 2024 08:11
@attiyaIshaque attiyaIshaque requested a review from a team as a code owner July 2, 2024 08:11
Copy link
Contributor

@syedsajjadkazmii syedsajjadkazmii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From where was the exception being raised? What will be the generated username if someone passes = as a name?

@attiyaIshaque
Copy link
Contributor Author

From where was the exception being raised? What will be the generated username if someone passes = as a name?

The username will be as expected

f"{current_year}{current_month}_{random_string}"

@attiyaIshaque attiyaIshaque force-pushed the attiya/VAN-1988-auto-generated_username-update branch from 54d8ec5 to c210385 Compare July 5, 2024 08:54
@attiyaIshaque attiyaIshaque merged commit 57dd213 into master Jul 5, 2024
49 checks passed
@attiyaIshaque attiyaIshaque deleted the attiya/VAN-1988-auto-generated_username-update branch July 5, 2024 09:23
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

mudassir-hafeez pushed a commit to mudassir-hafeez/edx-platform that referenced this pull request Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants