fix: should autogenerate username in tpa pipeline if feature is enabled #35101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syedsajjadkazmii
force-pushed
the
sajjad/auto-generate-username-tpa-pipeline
branch
from
0fe5918 to
52381c6
Compare
abdullahwaheed
approved these changes
Jul 9, 2024
| @@ -101,6 +102,7 @@ def B(*args, **kwargs): | |||
| ) | |||
| from common.djangoapps.track import segment | |||
| from common.djangoapps.util.json_request import JsonResponse | |||
| from openedx.core.djangoapps.user_authn.views.utils import get_auto_generated_username | |||
There was a problem hiding this comment.
we should group imports together
syedsajjadkazmii
force-pushed
the
sajjad/auto-generate-username-tpa-pipeline
branch
from
52381c6 to
9ec7164
Compare
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
|
2U Release Notice: This PR has been deployed to the edX production environment. |
mudassir-hafeez
pushed a commit
to mudassir-hafeez/edx-platform
that referenced
this pull request
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The user's username should be autogenerated without using the user's PII in the pipeline if the
is_auto_generated_username_enabled()is enabled.Useful information to include:
More details on autogenerate username feature can be found here: https://openedx.atlassian.net/wiki/spaces/OEPM/pages/4060938253/Proposal+Autogenerate+username+behind+a+flag
Supporting information
Link to other information about the change, such as Jira issues, GitHub issues, or Discourse discussions.
Be sure to check they are publicly readable, or if not, repeat the information here.
Testing instructions
Please provide detailed step-by-step instructions for testing this change.
Deadline
"None" if there's no rush, or provide a specific date or event (and reason) if there is one.
Other information
Include anything else that will help reviewers and consumers understand the change.