feat: removing the job runners in advance of removing the code #35115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@justinhynes pointed out that the task queues might be populated with the to-be-removed task during a blue-green deployment, and it makes sense to remove the job that queues up the tasks slated for removal _before_ removing the code for those tasks. FIXES: APER-3535
justinhynes
approved these changes
Jul 12, 2024
|
Thanks for splitting this out!! |
the task should never be called now FIXES: APER-3535
2 mocks were brought in an opposite order, but until this change, they always had the same result so nobody had noticed. FIXES: APER-3535
deborahgu
deleted the
dkaplan1/APER-3535_remove-tasks-before-visible-date-to-credentials-change
branch
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
|
2U Release Notice: This PR has been deployed to the edX production environment. |
mudassir-hafeez
pushed a commit
to mudassir-hafeez/edx-platform
that referenced
this pull request
Jul 24, 2024
…dx#35115) * @justinhynes pointed out that the task queues might be populated with the to-be-removed task during a blue-green deployment, and it makes sense to remove the job that queues up the tasks slated for removal _before_ removing the code for those tasks. * fixed a mock import order: 2 mocks were brought in an opposite order, but until this change, they always had the same result so nobody had noticed. FIXES: APER-3535
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@justinhynes pointed out that the task queues might be populated with the to-be-removed task during a blue-green deployment, and it makes sense to remove the job that queues up the tasks slated for removal before removing the code for those tasks.
FIXES: APER-3535