feat: fetched notifications based on time not date #35250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AhtishamShahid
approved these changes
Aug 8, 2024
asadazam93
reviewed
Aug 8, 2024
| end_date = datetime.datetime.combine(yesterday, datetime.time.max) | ||
| start_date = end_date | ||
| end_date = datetime.datetime.now() | ||
| start_date = end_date - datetime.timedelta(days=1, minutes=15) |
There was a problem hiding this comment.
I think making this 30 mins would be better
There was a problem hiding this comment.
I think 15 mins will be enough time. Normally, task status is changes from queued to in-progress in less than 15 minutes.
asadazam93
approved these changes
Aug 8, 2024
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
|
2U Release Notice: This PR has been deployed to the edX production environment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notifications will be fetched based on time instead of date.
For Weekly: Last 7 days
For Daily: Last 24 hours
15 minutes buffer time has been added for both cadence types.
Ticket: INF-1495