Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unpin lxml in edx-platform #35272

Closed
huniafatima-arbi opened this issue Aug 9, 2024 · 4 comments
Closed

unpin lxml in edx-platform #35272

huniafatima-arbi opened this issue Aug 9, 2024 · 4 comments

Comments

@huniafatima-arbi
Copy link
Contributor

lxml is pinned at lxml<5.0. lxml>=5.0 introduced breaking changes related to system dependencies
lxml==5.2.1 introduced new extra so we'll nee to rename lxml --> lxml[html-clean]
We have upgraded to python 3.12 so we can investigate and remove this constraint
@dianakhuang dianakhuang mentioned this issue Oct 10, 2024
Merged
@UsamaSadiq UsamaSadiq moved this to Todo in Arbi-BOM Oct 17, 2024
@mfarhan943 mfarhan943 self-assigned this Oct 18, 2024
@mfarhan943 mfarhan943 moved this from Todo to In Progress in Arbi-BOM Oct 18, 2024
@mfarhan943
Copy link
Contributor

Unpinning the lxml constraint causes test failures due to a segmentation fault.
Image

@mfarhan943 mfarhan943 moved this from In Progress to Todo in Arbi-BOM Oct 22, 2024
@mfarhan943 mfarhan943 removed their assignment Oct 22, 2024
@feanil
Copy link
Contributor

feanil commented Oct 24, 2024

This seems to be resolved via #35272

When both libxmlsce and lxml were updated in tandem, we did not see the segfault issue.

@BilalQamar95
Copy link
Contributor

Resolved via #35713

@feanil
Copy link
Contributor

feanil commented Nov 7, 2024

#35713 has now merged, this is now resolved.

@feanil feanil closed this as completed Nov 7, 2024
@github-project-automation github-project-automation bot moved this from Owner Review to Done in Arbi-BOM Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@feanil @BilalQamar95 @mfarhan943 @huniafatima-arbi