feat: create get_course_videos_qset API call #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This new call returns a CourseVideo queryset that will allow callers to efficiently get what they want, instead of having to bring back a large serialized object that may have many fields that they don't care about.
ormsbee
force-pushed
the
ormsbee/video-quality-optimization
branch
from
104c561 to
58bb15e
Compare
|
@DawoudSheraz: I'm just remaking #554 from this repo instead of my fork, to get around the Pact issue. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #557 +/- ##
==========================================
+ Coverage 94.57% 94.58% +0.01%
==========================================
Files 32 32
Lines 3171 3178 +7
Branches 122 122
==========================================
+ Hits 2999 3006 +7
Misses 154 154
Partials 18 18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
DawoudSheraz
approved these changes
Jan 17, 2025
ormsbee
added
the
performance
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new call returns a CourseVideo queryset that will allow callers to efficiently get what they want, instead of having to bring back a large serialized object that may have many fields that they don't care about.