forums v2: invalud parameters being passed to thread retrieval

[feoh]

Hi there folks;

We're trying to migrate to forums v2, and we're seeing the params object being unpacked into the get_user_threads function call and we're seeing a 'context' parameter that's causing this function to blow up with the following exception:

lms-1  | 2025-01-28 21:00:45,390 ERROR 13 [edx.courseware] views.py:622 - Error in /courses/course-v1:MITx+10.50.CH01x+1T2023/discussion/forum/: user=cpatti, effective_user=cpatti, course=course-v1:MITx+10.50.CH01x+1T2023
lms-1  | Traceback (most recent call last):
lms-1  |   File "/openedx/edx-platform/lms/djangoapps/courseware/views/views.py", line 534, in get
lms-1  |     return super().get(request, course=course, page_context=page_context, **kwargs)
lms-1  |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lms-1  |   File "/openedx/.local/lib/python3.11/site-packages/web_fragments/views.py", line 23, in get
lms-1  |     fragment = self.render_to_fragment(request, **kwargs)
lms-1  |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lms-1  |   File "/openedx/edx-platform/lms/djangoapps/courseware/views/views.py", line 688, in render_to_fragment
lms-1  |     return tab.render_to_fragment(request, course, **kwargs)
lms-1  |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lms-1  |   File "/openedx/edx-platform/xmodule/tabs.py", line 291, in render_to_fragment
lms-1  |     return self.fragment_view.render_to_fragment(request, course_id=str(course.id), **kwargs)
lms-1  |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lms-1  |   File "/openedx/edx-platform/lms/djangoapps/discussion/views.py", line 827, in render_to_fragment
lms-1  |     context = _create_discussion_board_context(request, base_context, thread=thread)
lms-1  |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lms-1  |   File "/openedx/edx-platform/lms/djangoapps/discussion/views.py", line 529, in _create_discussion_board_context
lms-1  |     threads, query_params = get_threads(request, course, user_info)   # This might process a search query
lms-1  |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lms-1  |   File "/openedx/edx-platform/lms/djangoapps/discussion/views.py", line 172, in get_threads
lms-1  |     paginated_results = cc.Thread.search(query_params)
lms-1  |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lms-1  |   File "/openedx/edx-platform/openedx/core/djangoapps/django_comment_common/comment_client/thread.py", line 83, in search
lms-1  |     response = forum_api.get_user_threads(**params)
lms-1  |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lms-1  | TypeError: get_user_threads() got an unexpected keyword argument 'context'

Here's a link to a public Sentry issue which has some more details on the exception.

Thanks in advance for any clues you can give us!

[feoh]

Public sentry issue: https://mit-office-of-digital-learning.sentry.io/share/issue/8d342f663d174d49a4cca60418eb8cd9/