-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: UI updates expired workflow #1264
feat: UI updates expired workflow #1264
Conversation
312f886
to
88449b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would look at renaming the usages of isEnded
to something a bit less ambiguous.
src/components/learner-credit-management/tests/BudgetCard.test.jsx
Outdated
Show resolved
Hide resolved
src/components/learner-credit-management/data/hooks/useSubsidyAccessPolicy.js
Outdated
Show resolved
Hide resolved
src/components/learner-credit-management/AssignmentAmountTableCell.jsx
Outdated
Show resolved
Hide resolved
src/components/learner-credit-management/AssignmentStatusTableCell.jsx
Outdated
Show resolved
Hide resolved
src/components/learner-credit-management/BudgetAssignmentsTable.jsx
Outdated
Show resolved
Hide resolved
src/components/learner-credit-management/BudgetDetailAssignments.jsx
Outdated
Show resolved
Hide resolved
src/components/learner-credit-management/data/hooks/useBudgetDetailTabs.jsx
Outdated
Show resolved
Hide resolved
80f5ad7
to
89949e5
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1264 +/- ##
==========================================
+ Coverage 85.40% 85.41% +0.01%
==========================================
Files 541 542 +1
Lines 11966 11991 +25
Branches 2519 2563 +44
==========================================
+ Hits 10219 10242 +23
- Misses 1689 1690 +1
- Partials 58 59 +1 ☔ View full report in Codecov by Sentry. |
eb0345b
to
f1ad334
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, this is looking good. I left several comments, but most are smaller, nit-level comments around simplifying the checks around BUDGET_STATUSES
. Given the check for retired/expired budget status is fairly commonplace now, I do wonder if it's worth creating a small util function (along the lines of isBudgetExpiredOrRetired
) or otherwise to use instead of re-implementing the same conditional in numerous places.
Beyond that, there were a couple other small suggestions as well including a clarifying question around a TODO
comment about abstracting status
higher up I'd be curious to learn more about.
src/components/learner-credit-management/AssignmentAmountTableCell.jsx
Outdated
Show resolved
Hide resolved
src/components/learner-credit-management/AssignmentStatusTableCell.jsx
Outdated
Show resolved
Hide resolved
src/components/learner-credit-management/AssignmentStatusTableCell.jsx
Outdated
Show resolved
Hide resolved
src/components/learner-credit-management/BudgetAssignmentsTable.jsx
Outdated
Show resolved
Hide resolved
src/components/learner-credit-management/BudgetDetailAssignments.jsx
Outdated
Show resolved
Hide resolved
src/components/learner-credit-management/SubBudgetCardUtilization.jsx
Outdated
Show resolved
Hide resolved
src/components/learner-credit-management/SubBudgetCardUtilization.jsx
Outdated
Show resolved
Hide resolved
src/components/learner-credit-management/data/hooks/useBudgetDetailTabs.jsx
Outdated
Show resolved
Hide resolved
f1ad334
to
dfc5fef
Compare
dfc5fef
to
f9faee6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! ✅ I'll merge this a bit later this morning, and help verify on stage (will let you know when it's deployed to stage).
For all changes
Ticket: ENT-9047
Figma: https://www.figma.com/design/gm4yVDt3TixtEi7aD6LETz/Learner-Credit-Expiration?node-id=489-19375&m=dev
Only if submitting a visual change