Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: port and password bug fixes in Reporting Configurations #1270

Merged
merged 4 commits into from
Aug 1, 2024

Conversation

sameeramin
Copy link
Contributor

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

feat: added name and id attributes to the form fields
feat: added name and id attributes to the form fields
Copy link

codecov bot commented Jul 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.47%. Comparing base (2dad691) to head (6405116).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1270      +/-   ##
==========================================
+ Coverage   85.43%   85.47%   +0.04%     
==========================================
  Files         554      554              
  Lines       12081    12081              
  Branches     2567     2530      -37     
==========================================
+ Hits        10321    10326       +5     
+ Misses       1702     1697       -5     
  Partials       58       58              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@MueezKhan246 MueezKhan246 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sameeramin sameeramin merged commit 67f42b7 into master Aug 1, 2024
6 checks passed
@sameeramin sameeramin deleted the sameeramin/ENT-8806 branch August 1, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants