Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: integrate csv download button on all plotly v2 charts and tables #1275

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

jajjibhai008
Copy link
Contributor

@jajjibhai008 jajjibhai008 commented Aug 19, 2024

Description

screencapture-localhost-1991-test-enterprise-admin-analyticsv2-2024-08-22-18_39_08

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented Aug 19, 2024

Codecov Report

Attention: Patch coverage is 92.75362% with 5 lines in your changes missing coverage. Please review.

Project coverage is 85.44%. Comparing base (ac64f8c) to head (57afd7c).
Report is 2 commits behind head on master.

Files Patch % Lines
src/data/services/EnterpriseDataApiService.js 25.00% 3 Missing ⚠️
...rc/components/AdvanceAnalyticsV2/data/constants.js 75.00% 1 Missing ⚠️
src/components/AdvanceAnalyticsV2/data/utils.js 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1275      +/-   ##
==========================================
+ Coverage   85.37%   85.44%   +0.07%     
==========================================
  Files         557      560       +3     
  Lines       12174    12232      +58     
  Branches     2576     2584       +8     
==========================================
+ Hits        10393    10452      +59     
+ Misses       1722     1721       -1     
  Partials       59       59              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jajjibhai008 jajjibhai008 force-pushed the eahmadjaved/ENT-9261 branch 3 times, most recently from f454ef1 to 244c04f Compare August 22, 2024 13:37
@jajjibhai008 jajjibhai008 merged commit 7388dfc into master Aug 27, 2024
7 checks passed
@jajjibhai008 jajjibhai008 deleted the eahmadjaved/ENT-9261 branch August 27, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants