Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add banner to library content picker modal #1485

Open
jmakowski1123 opened this issue Nov 7, 2024 · 6 comments
Open

Add banner to library content picker modal #1485

jmakowski1123 opened this issue Nov 7, 2024 · 6 comments
Assignees
Labels
bug Report of or fix for something that isn't working as intended

Comments

@jmakowski1123
Copy link

jmakowski1123 commented Nov 7, 2024

As an author, I might get confused about why I don't see all my library content from the Library Content Picker modal I need a visual indicator that tells me I am only able to see published content from this modal.

Add a banner that says "Only published content is visible and available for reuse" to the top of the Library Content Picker modal.

Screenshot 2024-11-07 at 3 24 25 PM

@jmakowski1123 jmakowski1123 converted this from a draft issue Nov 7, 2024
@jmakowski1123 jmakowski1123 added the bug Report of or fix for something that isn't working as intended label Nov 7, 2024
@bradenmacdonald
Copy link
Contributor

bradenmacdonald commented Nov 7, 2024

@jmakowski1123 This is the "course search modal":

Screenshot 2024-11-07 at 3 22 06 PM

You mean the "Library Content Picker modal" right? :)

Screenshot 2024-11-07 at 3 24 25 PM

@bradenmacdonald bradenmacdonald changed the title Add banner to course search modal Add banner to library content picker modal Nov 8, 2024
@bradenmacdonald
Copy link
Contributor

@jmakowski1123 Should this banner be included in Sumac as well?

@jmakowski1123
Copy link
Author

Yes, I meant the Library Content Picker modal!

If this is acceptable to get into Sumac, let's aim for that.

@pomegranited
Copy link
Contributor

Another option would be to change the Search box placeholder text to "Search published content" -- if anyone reads that?

@navinkarkera
Copy link
Contributor

@jmakowski1123 @lizc577 @sdaitzman @marcotuts This is ready for AC testing on the sandbox

@navinkarkera navinkarkera moved this from Backlog to Ready for AC testing in Libraries Overhaul Nov 23, 2024
@sdaitzman
Copy link

Looks good to me!

The number of concentric visual containers here (box inside a shadow inside a box inside a box inside a shadow) is a bit visually busy, and worth improving in some future update, but I don't think it needs to be a blocker/priority right now.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Report of or fix for something that isn't working as intended
Projects
Status: Ready for AC testing
Development

No branches or pull requests

5 participants