Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem Bank "Add Components" modal is way too long in unit page iframe. #1502

Open
bradenmacdonald opened this issue Nov 14, 2024 · 4 comments
Assignees
Labels
bug Report of or fix for something that isn't working as intended

Comments

@bradenmacdonald
Copy link
Contributor

If you have a unit with many components and a problem bank on the NEW MFE unit page (with an iframe), clicking "Add Components" will open a modal that's way too tall.

This only affects the new unit page, not the legacy page.

Note that we are planning to overhaul this workflow in #1096 but that work is delayed until we get more use feedback.

Screenshot 2024-11-14 at 11 21 46 AM

Screenshot 2024-11-14 at 11 21 19 AM

@bradenmacdonald bradenmacdonald added the bug Report of or fix for something that isn't working as intended label Nov 14, 2024
@bradenmacdonald bradenmacdonald moved this to In grooming in Libraries Overhaul Nov 14, 2024
@navinkarkera
Copy link
Contributor

@bradenmacdonald Should we intercept the Add components button click and open the modal in MFE similar to #1464. I am almost done with #1464 and this should be similar.

@bradenmacdonald
Copy link
Contributor Author

@navinkarkera If it's an easy change, I think that would be a nice fix.

@navinkarkera
Copy link
Contributor

@bradenmacdonald Yes, we can show the modal on MFE side and still handle the adding blocks part in legacy by sending message to the iframe.

@navinkarkera
Copy link
Contributor

@jmakowski1123 @lizc577 @sdaitzman @marcotuts This is ready for AC testing on the sandbox

@navinkarkera navinkarkera moved this from In grooming to Ready for AC testing in Libraries Overhaul Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Report of or fix for something that isn't working as intended
Projects
Status: Ready for AC testing
Development

No branches or pull requests

2 participants