Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Persian language #555

Merged
merged 2 commits into from
Oct 24, 2023
Merged

fix: Persian language #555

merged 2 commits into from
Oct 24, 2023

Conversation

CodeWithEmad
Copy link
Member

This will fix the Persian language code issue(fa-ir is the code in all of the other MFEs)
also fixed some typos in the code.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Aug 8, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Aug 8, 2023 •
edited
Loading

Thanks for the pull request, @CodeWithEmad! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@CodeWithEmad
Copy link
Member Author

Also, I noticed that you're using the es-AR and es-ES inside i18n/index.js

frontend-app-discussions/src/i18n/index.js

Lines 41 to 42 in ea235cf

'es-AR': esARMessages,
'es-ES': esESMessages,

but I believe in other MFEs (even here of fr-fr or fr-cs) the language code should be all in lowercase.

Is there a specific reason for the issue, or should I address it in my PR?

@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Aug 8, 2023
@itsjeyd
Copy link

itsjeyd commented Aug 15, 2023

Hey @asadazam93, would you be able to help @CodeWithEmad with the question that he raised above?

@CodeWithEmad Thanks for the changes!

@itsjeyd itsjeyd added the question Further information is requested label Aug 15, 2023
@codecov
Copy link

codecov bot commented Aug 16, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3a6a783) 92.32% compared to head (1c64979) 92.32%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #555   +/-   ##
=======================================
  Coverage   92.32%   92.32%           
=======================================
  Files         169      169           
  Lines        3451     3451           
  Branches      899      899           
=======================================
  Hits         3186     3186           
  Misses        244      244           
  Partials       21       21
Files Coverage Δ
src/discussions/common/ActionsDropdown.jsx 87.50% <100.00%> (ø)
src/discussions/common/Confirmation.jsx 100.00% <ø> (ø)
src/discussions/common/HoverCard.jsx 86.20% <100.00%> (ø)
src/discussions/data/selectors.js 100.00% <100.00%> (ø)
...discussions/discussions-home/DiscussionSidebar.jsx 89.18% <100.00%> (ø)
...c/discussions/discussions-home/DiscussionsHome.jsx 95.74% <ø> (ø)
.../discussions-home/DiscussionsRestrictionBanner.jsx 88.88% <100.00%> (ø)
...c/discussions/discussions-home/FeedbackWrapper.jsx 92.85% <100.00%> (ø)
src/discussions/learners/LearnersView.jsx 97.43% <100.00%> (ø)
...iscussions/post-comments/comments/CommentsView.jsx 91.42% <100.00%> (ø)
... and 9 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@e0d
Copy link

e0d commented Aug 16, 2023

Hi @CodeWithEmad , I notice there are some commit-lint failures. Please note that we use conventional commits across Open edX projects. You can read about the details here. Can you please amend your commit messages to follow our standard?

@CodeWithEmad
Copy link
Member Author

Sure. I totally forgot about the commit lint. have a look now :)

@e0d e0d removed question Further information is requested needs test run Author's first PR to this repository, awaiting test authorization from Axim labels Aug 16, 2023
@e0d e0d requested a review from arbrandes August 16, 2023 20:49
@CodeWithEmad CodeWithEmad force-pushed the persian-language branch 2 times, most recently from 4ca85b0 to 010702d Compare August 16, 2023 21:28
@CodeWithEmad
Copy link
Member Author

@e0d since no one answered my question about the UPPER case codes for es-ES and es-AR, I refactor them as well to es-es and es-ar and rebased with master.

@itsjeyd itsjeyd added the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Aug 22, 2023
@itsjeyd
Copy link

itsjeyd commented Aug 22, 2023

Hey @arbrandes, has this PR made it into your review queue? If you don't think you'll get to this PR anytime soon, I can try and find someone else to review; just let me know.

@mphilbrick211
Copy link

Hi @arbrandes! Just following up on this to see if you're able to review (and if you could please re-enable the checks to run)? Thanks!

CC: @itsjeyd

@itsjeyd itsjeyd added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Sep 13, 2023
@arbrandes arbrandes mentioned this pull request Sep 20, 2023
Closed
@itsjeyd itsjeyd removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Sep 21, 2023
@itsjeyd
Copy link

itsjeyd commented Sep 26, 2023

@arbrandes Since your review queue is quite long (😅), would it help if we asked someone from the maintainer team (Infinity) to review this PR?

CC @mphilbrick211

@awais-ansari awais-ansari added engineering review and removed waiting for eng review PR is ready for review. Review and merge it, or suggest changes. labels Sep 26, 2023
saadyousafarbi
saadyousafarbi approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@saadyousafarbi saadyousafarbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CodeWithEmad can you please rebase and squash your commits? Thanks!

@CodeWithEmad
Copy link
Member Author

@saadyousafarbi take a look.

@e0d
Copy link

e0d commented Oct 12, 2023

I notice there are some commit-lint failures. Please note that we use conventional commits across Open edX projects. You can read about the details here. Can you please amend your commit messages to follow our standard?

@CodeWithEmad CodeWithEmad force-pushed the persian-language branch 2 times, most recently from ab2d383 to b3a603e Compare October 12, 2023 14:12
@CodeWithEmad
Copy link
Member Author

Oops. I forgot that, again!
It's okay now, @e0d.

@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Oct 13, 2023
@mphilbrick211
Copy link

Hi @arbrandes! When you get a chance, could you please re-enable the checks to run on this PR before review? Thanks!

@itsjeyd
Copy link

itsjeyd commented Oct 17, 2023

@mphilbrick211 @arbrandes Since @saadyousafarbi already reviewed and approved these changes I didn't think we'd need another round of review.

The build is green, too, so it looks like this PR is pretty much ready for merge.

@e0d e0d removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Oct 17, 2023
@itsjeyd
Copy link

itsjeyd commented Oct 24, 2023

Hey @CodeWithEmad, could you please rebase your changes?

@saadyousafarbi Once that's done would you be able to merge this PR?

@itsjeyd itsjeyd added the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Oct 24, 2023
@CodeWithEmad @awais-ansari
fix: corrected typos
ee26a8a 
comfirm -> confirm
varaint -> variant
Privilaged -> Privileged
courseare, coursweare  -> courseware
Discssion -> Discussion
dimentions -> dimensions
@CodeWithEmad @awais-ansari
refactor: clean up language codes
1c64979
@awais-ansari awais-ansari merged commit 5db3a18 into openedx:master Oct 24, 2023
@openedx-webhooks
Copy link

@CodeWithEmad 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@awais-ansari awais-ansari added merged and removed engineering review waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. labels Oct 24, 2023
@CodeWithEmad CodeWithEmad deleted the persian-language branch October 24, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awais-ansari awais-ansari awais-ansari approved these changes

@saadyousafarbi saadyousafarbi saadyousafarbi approved these changes

@arbrandes arbrandes Awaiting requested review from arbrandes

Assignees
No one assigned
Labels
merged open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@CodeWithEmad @openedx-webhooks @itsjeyd @e0d @mphilbrick211 @saadyousafarbi @awais-ansari