-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: modified TA icon according to role #664
Conversation
Thanks for the pull request, @sohailfatima! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. Once you've signed the CLA, please allow 1 business day for it to be processed. After this time, you can re-run the CLA check by adding a comment here that you have signed it. If the problem persists, you can tag the |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #664 +/- ##
==========================================
- Coverage 92.76% 92.76% -0.01%
==========================================
Files 156 156
Lines 3304 3303 -1
Branches 903 905 +2
==========================================
- Hits 3065 3064 -1
Misses 219 219
Partials 20 20 ☔ View full report in Codecov by Sentry. |
hi @sohailfatima! Thank you for this contribution. Please let me know if you have any questions regarding submitting a CLA form. Thanks! |
@mphilbrick211 fatima's CLA form has been submitted, but still have not received any update regarding it. |
@sohailfatima I have not received your CLA form submission. Could you kindly resubmit the form? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
created another PR due to CLA #665 |
@sohailfatima Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
@ehuthmacher just submitted it for future contributions. |
@sohailfatima Received, thank you. It is processing with our Legal department now. |
INF-737
Description
Modified TA icons to include tool-tips and add a moderator label.
Corresponding backend PR: openedx/edx-platform#34218
Before:
Screen.Recording.2024-02-12.at.7.08.24.PM.mov
After:
Screen.Recording.2024-02-12.at.7.03.05.PM.mov