Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: modified TA icon according to role #664

Closed
wants to merge 7 commits into from
Closed

feat: modified TA icon according to role #664

wants to merge 7 commits into from

Conversation

sohailfatima
Copy link
Contributor

@sohailfatima sohailfatima commented Feb 12, 2024

INF-737

Description

Modified TA icons to include tool-tips and add a moderator label.
Corresponding backend PR: openedx/edx-platform#34218

Before:

Screen.Recording.2024-02-12.at.7.08.24.PM.mov

After:

Screen.Recording.2024-02-12.at.7.03.05.PM.mov

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Feb 12, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @sohailfatima! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

⚠️ We can't start reviewing your pull request until you've submitted a signed contributor agreement or indicated your institutional affiliation. Please see the CONTRIBUTING file for more information. If you've signed an agreement in the past, you may need to re-sign. See The New Home of the Open edX Codebase for details.

Once you've signed the CLA, please allow 1 business day for it to be processed. After this time, you can re-run the CLA check by adding a comment here that you have signed it. If the problem persists, you can tag the @openedx/cla-problems team in a comment on your PR for further assistance.

Copy link

codecov bot commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9eaed2b) 92.76% compared to head (a1275a5) 92.76%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #664      +/-   ##
==========================================
- Coverage   92.76%   92.76%   -0.01%     
==========================================
  Files         156      156              
  Lines        3304     3303       -1     
  Branches      903      905       +2     
==========================================
- Hits         3065     3064       -1     
  Misses        219      219              
  Partials       20       20              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/discussions/common/AuthorLabel.jsx Outdated Show resolved Hide resolved
src/discussions/common/AuthorLabel.jsx Outdated Show resolved Hide resolved
src/discussions/common/AuthorLabel.test.jsx Outdated Show resolved Hide resolved
@mphilbrick211
Copy link

hi @sohailfatima! Thank you for this contribution. Please let me know if you have any questions regarding submitting a CLA form. Thanks!

@ayesha-waris
Copy link
Contributor

hi @sohailfatima! Thank you for this contribution. Please let me know if you have any questions regarding submitting a CLA form. Thanks!

@mphilbrick211 fatima's CLA form has been submitted, but still have not received any update regarding it.

src/discussions/common/AuthorLabel.jsx Outdated Show resolved Hide resolved
src/discussions/common/AuthorLabel.jsx Outdated Show resolved Hide resolved
@ehuthmacher
Copy link

@sohailfatima I have not received your CLA form submission. Could you kindly resubmit the form?

Copy link
Contributor

@ayesha-waris ayesha-waris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ayesha-waris
Copy link
Contributor

created another PR due to CLA #665

@openedx-webhooks
Copy link

@sohailfatima Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

@sohailfatima
Copy link
Contributor Author

@sohailfatima I have not received your CLA form submission. Could you kindly resubmit the form?

@ehuthmacher just submitted it for future contributions.

@ehuthmacher
Copy link

@sohailfatima Received, thank you. It is processing with our Legal department now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

7 participants