Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: convert download button to stateful button #461

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

omar-sarfraz
Copy link
Member

Ticket: ENT-9740

1. Fixed the button hitbox issue caused by negative margin.

Screen.Recording.2025-01-02.at.5.57.15.PM.mov

2. Converted the button to a stateful button.

Screen.Recording.2025-01-03.at.5.22.40.PM.mov

3. Fixed the button's overlapping issue for tablet size screens.

4. Center aligned the "Courses" heading with "See all" link.

Before

image

After

image

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.11%. Comparing base (9260cbd) to head (07bd502).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ents/catalogSearchResults/CatalogSearchResults.jsx 0.00% 1 Missing ⚠️
...Components/downloadCsvButton/DownloadCsvButton.jsx 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #461      +/-   ##
==========================================
+ Coverage   78.00%   78.11%   +0.10%     
==========================================
  Files          43       43              
  Lines         891      900       +9     
  Branches      241      248       +7     
==========================================
+ Hits          695      703       +8     
- Misses        188      189       +1     
  Partials        8        8              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mahamakifdar19 mahamakifdar19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jajjibhai008 jajjibhai008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jajjibhai008 jajjibhai008 merged commit 9765898 into openedx:main Jan 8, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants