Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime config work #231

Closed

Conversation

httpsmenahassan
Copy link
Contributor

No description provided.

@hurtstotouchfire hurtstotouchfire added the needs maintainer attention Issue or PR specifically needs the attention of the maintainer. label Nov 20, 2023
@justinhynes
Copy link
Contributor

Hi @httpsmenahassan!

I'm checking in on this PR. Is this something that is still required? It doesn't look like it's had any changes since Nov 20th, there isn't a description (so I'm not sure the context of the changes), and it currently has some conflicts that need to be resolved?

Can this be closed? If not, could you fix the conflicts and provide some information to the change? I can try and get this looked at this week. Thanks!

@justinhynes justinhynes added waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. and removed needs maintainer attention Issue or PR specifically needs the attention of the maintainer. labels Jan 8, 2024
@justinhynes
Copy link
Contributor

Hi @httpsmenahassan -- I haven't heard back from you so I am going to close this PR for now. Please resubmit if this is needed. Thanks!

@justinhynes justinhynes closed this Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants