refactor: remove unused cookies.js util file
#296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When assessing the code coverage for the project, I noticed that the `setCookie` and `getCookie` utility functions had zero coverage. When trying to determine where this functionality is used, I couldn't find it being used or imported anywhere in the project. After a bit of looking around, it looks like the it was missed in some recent cleanup. See #112 which removed the use of `setCookie` and `getCookie` but didn't remove these utility functions.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #296 +/- ##
==========================================
+ Coverage 96.19% 96.69% +0.50%
==========================================
Files 184 183 -1
Lines 1734 1725 -9
Branches 309 308 -1
==========================================
Hits 1668 1668
+ Misses 61 53 -8
+ Partials 5 4 -1 ☔ View full report in Codecov by Sentry. |
deborahgu
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When assessing the code coverage for the project, I noticed that the
setCookieandgetCookieutility functions had zero coverage.When trying to determine where this functionality is used, I couldn't find it being used or imported anywhere in the project.
After a bit of looking around, it looks like the it was missed in some recent cleanup. See #112 which removed the use of
setCookieandgetCookiebut didn't remove these utility functions.