Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unused constants #547

Closed
wants to merge 1 commit into from

Conversation

MaxFrank13
Copy link
Member

These were missed from the removal of the UpgradeButton (#536)

@MaxFrank13 MaxFrank13 requested a review from a team as a code owner January 14, 2025 14:36
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.71%. Comparing base (777d3aa) to head (8962bfb).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #547      +/-   ##
==========================================
- Coverage   96.72%   96.71%   -0.01%     
==========================================
  Files         155      155              
  Lines        1372     1371       -1     
  Branches      229      229              
==========================================
- Hits         1327     1326       -1     
  Misses         43       43              
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MaxFrank13
Copy link
Member Author

Closing this in favor of #548. Apologies for the confusion. While re-implementing the PluginSlot logic for CourseCardActionSlot in #536, the removal of the actual UpgradeButton.jsx was missed

@MaxFrank13 MaxFrank13 closed this Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants