Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Product interview sidebar #75

Closed
wants to merge 3 commits into from
Closed

Product interview sidebar #75

wants to merge 3 commits into from

Conversation

zacharis278
Copy link

@zacharis278 zacharis278 commented Nov 28, 2022 •
edited
Loading

MST-1703

Add widget for scheduling product team interviews

Screen Shot 2022-11-28 at 9 30 44 AM

@zacharis278 zacharis278 requested a review from a team November 28, 2022 14:21
alangsto
alangsto approved these changes Nov 28, 2022
View reviewed changes
Copy link

@alangsto alangsto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@muselesscreator
Copy link
Contributor

Looks fine to me, though we are opting to hold until we are finished releasing.
Only issue is that we would prefer an svg image if possible over the png.

mattcarter
mattcarter approved these changes Nov 30, 2022
View reviewed changes
Copy link
Contributor

@mattcarter mattcarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

wittjeff
wittjeff suggested changes Dec 14, 2022
View reviewed changes
src/containers/WidgetContainers/LoadedSidebar/index.jsx
@@ -1,9 +1,13 @@
import React from 'react';

import InterviewWidget from 'widgets/InterviewWidget';
import RecommendationsPanel from 'widgets/RecommendationsPanel';

export const WidgetSidebar = () => (
<div className="widget-sidebar">
Copy link

@wittjeff wittjeff Dec 14, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make this an aside element?

@justinhynes
Copy link
Contributor

Hi @zacharis278!

I'm trying to check up on some open PRs for this repo. Is this change still needed? If not, may I close it? If so, could you address the open requests and fix the conflicts on the PR?

Thanks in advance!

@justinhynes justinhynes added the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Jan 8, 2024
@zacharis278
Copy link
Author

@justinhynes releasing this was put on hold by the product team so it's fallen way behind main. I'll have to check in on if/when this can actually be merged and get back to you.

@justinhynes
Copy link
Contributor

Considering this is over a year old without much movement, I'm going to close this PR. Please resubmit a PR if this becomes a priority again. Thanks!

@justinhynes justinhynes closed this Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wittjeff wittjeff wittjeff requested changes

@alangsto alangsto alangsto approved these changes

@mattcarter mattcarter mattcarter approved these changes

Assignees
No one assigned
Labels
waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@zacharis278 @muselesscreator @justinhynes @mattcarter @wittjeff @alangsto