From 48ca308a2dcde09e9ebb45ddf12ee5a24839dfe4 Mon Sep 17 00:00:00 2001
From: Justin Hynes <Jhynes@edx.org>
Date: Mon, 23 Oct 2023 19:32:17 +0000
Subject: [PATCH] feat!: Remove unused feature flag

[APER-2922]

This PR removes the `USE_LR_MFE` feature flag. This feature flag was initially added to redirect learners back to the legacy frontend in Credentials when viewing a Program Record. This was so we could release the Learner Record MFE in phases while we were implementing the design.

Now that the legacy frontend has been removed from Credentials, this functionality and feature flag is no longer needed.
---
 .env.development                              |  1 -
 README.rst                                    | 13 +++---
 .../ProgramRecordsList/ProgramRecordsList.jsx |  2 +-
 src/index.jsx                                 | 41 ++++++++-----------
 4 files changed, 25 insertions(+), 32 deletions(-)

diff --git a/.env.development b/.env.development
index 9f657f2c..2524bd60 100644
--- a/.env.development
+++ b/.env.development
@@ -20,7 +20,6 @@ SEGMENT_KEY=''
 SITE_NAME=localhost
 USER_INFO_COOKIE_NAME='edx-user-info'
 SUPPORT_URL_LEARNER_RECORDS='https://support.edx.org/hc/en-us/sections/360001216693-Learner-records'
-USE_LR_MFE='true'
 APP_ID=''
 MFE_CONFIG_API_URL=''
 ENABLE_VERIFIABLE_CREDENTIALS='true'
diff --git a/README.rst b/README.rst
index 05fd19e5..7fe1b9ae 100644
--- a/README.rst
+++ b/README.rst
@@ -77,16 +77,15 @@ Environment Variables/Setup Notes
 
 Currently, this MFE is not intergrated into the devstack, and must be run locally. This MFE requires credentials to be running, and will use a REST API from the Credentials IDA located at `credentials/apps/records/rest_api`.
 
-Credentials uses 2 enviroment variables to link to this MFE:
+Credentials requires configuring a Django setting to support directing traffic to the Learner Record MFE:
 
-* ``USE_LEARNER_RECORD_MFE`` -- Toggles the navigation in credentials to redirect to this MFE
-* ``LEARNER_RECORD_MFE_RECORDS_PAGE_URL`` -- The URL for the base URL of this MFE
+* ``LEARNER_RECORD_MFE_RECORDS_PAGE_URL`` -- The base URL of the Learne Record MFE
 
-More details for these flags can be found in the base configuration of credentials: ``credentials/settings/base``
-This MFE has 2 flags of its own:
+For more info, see the Learner Records documentation on ReadTheDocs: https://edx-credentials.readthedocs.io/en/latest/learner_records.html.
+
+This MFE has a setting of its own:
 
 * ``SUPPORT_URL_LEARNER_RECORDS`` -- A link to a help/support center for learners who run into problems whilst trying to share their records
-* ``USE_LR_MFE`` -- A toggle that when on, uses the MFE to host shared records instead of the the old UI inside of credentials
 
 Verifiable Credentials
 ......................
@@ -188,4 +187,4 @@ Please do not report security issues in public. Please email security@openedx.or
 .. |Codecov| image:: https://codecov.io/gh/edx/frontend-app-learner-record/branch/master/graph/badge.svg
    :target: https://codecov.io/gh/edx/frontend-app-learner-record
 .. |license| image:: https://img.shields.io/npm/l/@edx/frontend-app-learner-record.svg
-   :target: https://github.com/openedx/frontend-app-learner-record/blob/master/LICENSE
\ No newline at end of file
+   :target: https://github.com/openedx/frontend-app-learner-record/blob/master/LICENSE
diff --git a/src/components/ProgramRecordsList/ProgramRecordsList.jsx b/src/components/ProgramRecordsList/ProgramRecordsList.jsx
index 9da2ba4a..53ee9d3d 100644
--- a/src/components/ProgramRecordsList/ProgramRecordsList.jsx
+++ b/src/components/ProgramRecordsList/ProgramRecordsList.jsx
@@ -115,7 +115,7 @@ function ProgramRecordsList() {
             <div className="d-flex align-items-center pt-3 pt-lg-0">
               <Hyperlink
                 variant="muted"
-                destination={getConfig().USE_LR_MFE ? `/${record.uuid}` : `${getConfig().CREDENTIALS_BASE_URL}/records/programs/${record.uuid}/`}
+                destination={`/${record.uuid}`}
               >
                 <Button variant="outline-primary">
                   <FormattedMessage
diff --git a/src/index.jsx b/src/index.jsx
index 3cd64c35..ca06a6e8 100644
--- a/src/index.jsx
+++ b/src/index.jsx
@@ -25,30 +25,26 @@ subscribe(APP_READY, () => {
       <HelmetProvider>
         <Head />
         <Header />
-        {getConfig().USE_LR_MFE ? (
-          <Routes>
+        <Routes>
+          <Route
+            path={ROUTES.PROGRAM_RECORDS}
+            element={<AuthenticatedPageRoute><ProgramRecordsList /></AuthenticatedPageRoute>}
+          />
+          <Route
+            path={ROUTES.PROGRAM_RECORD_SHARED}
+            element={<ProgramRecord isPublic />}
+          />
+          <Route
+            path={ROUTES.PROGRAM_RECORD_ITEM}
+            element={<AuthenticatedPageRoute><ProgramRecord isPublic={false} /></AuthenticatedPageRoute>}
+          />
+          {getConfig().ENABLE_VERIFIABLE_CREDENTIALS && (
             <Route
-              path={ROUTES.PROGRAM_RECORDS}
-              element={<AuthenticatedPageRoute><ProgramRecordsList /></AuthenticatedPageRoute>}
+              path={ROUTES.VERIFIABLE_CREDENTIALS}
+              element={<AuthenticatedPageRoute><ProgramCertificatesList /></AuthenticatedPageRoute>}
             />
-            {getConfig().ENABLE_VERIFIABLE_CREDENTIALS && (
-              <Route
-                path={ROUTES.VERIFIABLE_CREDENTIALS}
-                element={<AuthenticatedPageRoute><ProgramCertificatesList /></AuthenticatedPageRoute>}
-              />
-            )}
-            <Route
-              path={ROUTES.PROGRAM_RECORD_SHARED}
-              element={<ProgramRecord isPublic />}
-            />
-            <Route
-              path={ROUTES.PROGRAM_RECORD_ITEM}
-              element={<AuthenticatedPageRoute><ProgramRecord isPublic={false} /></AuthenticatedPageRoute>}
-            />
-          </Routes>
-        ) : (
-          <ProgramRecordsList />
-        )}
+          )}
+        </Routes>
         <Footer />
       </HelmetProvider>
     </AppProvider>,
@@ -65,7 +61,6 @@ initialize({
     config: () => {
       mergeConfig({
         SUPPORT_URL_LEARNER_RECORDS: process.env.SUPPORT_URL_LEARNER_RECORDS || '',
-        USE_LR_MFE: process.env.USE_LR_MFE || false,
         ENABLE_VERIFIABLE_CREDENTIALS: process.env.ENABLE_VERIFIABLE_CREDENTIALS || false,
         SUPPORT_URL_VERIFIABLE_CREDENTIALS: process.env.SUPPORT_URL_VERIFIABLE_CREDENTIALS || '',
       }, 'LearnerRecordConfig');