From 5b7332f90d9b2075b7b70e4e13b374794634ee1b Mon Sep 17 00:00:00 2001
From: Maxwell Frank <mfrank@2u.com>
Date: Wed, 21 Aug 2024 18:14:21 +0000
Subject: [PATCH 1/2] chore: test against node 18 in CI

---
 .github/workflows/ci.yml | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index bc014d08..57146ae9 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -3,18 +3,19 @@ on: [push, pull_request]
 jobs:
   tests:
     runs-on: ubuntu-latest
-
+    strategy:
+      matrix:
+        node: [18, 20]
+      coninue-on-error: ${{ matrix.node == 20 }}
     steps:
     - name: Checkout
       uses: actions/checkout@v4
       with:
         fetch-depth: 0
-    - name: Setup Nodejs Env
-      run: echo "NODE_VER=`cat .nvmrc`" >> $GITHUB_ENV
     - name: Setup Nodejs
       uses: actions/setup-node@v4
       with:
-        node-version: ${{ env.NODE_VER }}
+        node-version: ${{ matrix.node }}
     - name: Install dependencies
       run: npm ci
     - name: Validate package-lock.json changes

From a52b84d3fb95ffb23fe5012fabe43bebd6abf2bf Mon Sep 17 00:00:00 2001
From: Maxwell Frank <mfrank@2u.com>
Date: Thu, 22 Aug 2024 13:33:51 +0000
Subject: [PATCH 2/2] fix: remove line

---
 .github/workflows/ci.yml | 1 -
 1 file changed, 1 deletion(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 57146ae9..3a1650ee 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -6,7 +6,6 @@ jobs:
     strategy:
       matrix:
         node: [18, 20]
-      coninue-on-error: ${{ matrix.node == 20 }}
     steps:
     - name: Checkout
       uses: actions/checkout@v4