Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make notification trigger default to open for audit user #1233

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

leangseu-edx
Copy link
Contributor

No description provided.

@leangseu-edx leangseu-edx force-pushed the lk/change-default-notification-tray branch from 34f1468 to 437b645 Compare November 8, 2023 20:34
Copy link
Contributor

@mattcarter mattcarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (9a0cdc0) 88.20% compared to head (437b645) 88.19%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1233      +/-   ##
==========================================
- Coverage   88.20%   88.19%   -0.01%     
==========================================
  Files         274      274              
  Lines        4628     4627       -1     
  Branches     1165     1165              
==========================================
- Hits         4082     4081       -1     
  Misses        532      532              
  Partials       14       14              
Files Coverage Δ
src/courseware/course/Course.jsx 88.88% <60.00%> (-0.31%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leangseu-edx leangseu-edx merged commit 308f03c into master Nov 8, 2023
3 of 5 checks passed
@leangseu-edx leangseu-edx deleted the lk/change-default-notification-tray branch November 8, 2023 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants