Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(AU-1949): Restrict WCT to verified track learners only #1345

Merged
merged 3 commits into from
Apr 8, 2024

Conversation

Rodra
Copy link
Contributor

@Rodra Rodra commented Apr 5, 2024

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.25%. Comparing base (85b95ad) to head (96e8b6d).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1345      +/-   ##
==========================================
+ Coverage   88.24%   88.25%   +0.01%     
==========================================
  Files         293      293              
  Lines        4992     4997       +5     
  Branches     1266     1267       +1     
==========================================
+ Hits         4405     4410       +5     
  Misses        571      571              
  Partials       16       16              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

useModel.mockReturnValue({ language: 'en' });
useModel
.mockReturnValueOnce({ language: 'en' })
.mockReturnValueOnce({ verifiedMode: { accessExpirationDate: null } });
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to use jest-when to mock instead. This rely on the order of the useModel get call in index.jsx file.

Copy link
Contributor

@leangseu-edx leangseu-edx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Rodra Rodra merged commit 23e522e into master Apr 8, 2024
7 checks passed
@Rodra Rodra deleted the feat/AU-1949 branch April 8, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants