Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix translation for verified student only logic #1354

Merged
merged 2 commits into from
Apr 15, 2024

Conversation

leangseu-edx
Copy link
Contributor

@leangseu-edx leangseu-edx commented Apr 12, 2024

The previous check were unreliable

@leangseu-edx leangseu-edx requested a review from Rodra April 12, 2024 18:13
Copy link

codecov bot commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.25%. Comparing base (1086367) to head (e53a80b).

❗ Current head e53a80b differs from pull request most recent head c4a1afc. Consider uploading reports for the commit c4a1afc to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1354   +/-   ##
=======================================
  Coverage   88.25%   88.25%           
=======================================
  Files         293      293           
  Lines        4997     4997           
  Branches     1264     1264           
=======================================
  Hits         4410     4410           
  Misses        571      571           
  Partials       16       16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leangseu-edx leangseu-edx merged commit 2347ce8 into master Apr 15, 2024
5 checks passed
@leangseu-edx leangseu-edx deleted the lk/translation-only-for-verified branch April 15, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants