Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make sidebar less intrusive for mobile #1377

Merged
merged 3 commits into from
May 14, 2024

Conversation

leangseu-edx
Copy link
Contributor

@leangseu-edx leangseu-edx commented May 1, 2024

Ticket: https://2u-internal.atlassian.net/browse/AU-1930

What changed?

  • Mobile user will only need to need to close the notifications once.

@leangseu-edx leangseu-edx force-pushed the lk/sidebar-intrusive-fix branch from 59f7817 to 86085db Compare May 1, 2024 13:52
Copy link

codecov bot commented May 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.74%. Comparing base (1857b86) to head (4bd85c4).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1377   +/-   ##
=======================================
  Coverage   88.73%   88.74%           
=======================================
  Files         303      303           
  Lines        5222     5224    +2     
  Branches     1326     1297   -29     
=======================================
+ Hits         4634     4636    +2     
  Misses        572      572           
  Partials       16       16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leangseu-edx leangseu-edx force-pushed the lk/sidebar-intrusive-fix branch 4 times, most recently from ed9e13e to 253d5e1 Compare May 13, 2024 21:13
@leangseu-edx leangseu-edx force-pushed the lk/sidebar-intrusive-fix branch from 253d5e1 to 04b8e62 Compare May 14, 2024 14:23
Copy link
Member

@BrandonHBodine BrandonHBodine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@leangseu-edx leangseu-edx merged commit 257c9dc into master May 14, 2024
7 checks passed
@leangseu-edx leangseu-edx deleted the lk/sidebar-intrusive-fix branch May 14, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants