Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prompt authentication error message when xblock is not publicly accessible #1492

Closed

Conversation

qasimgulzar
Copy link

@qasimgulzar qasimgulzar commented Sep 27, 2024

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Sep 27, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @qasimgulzar!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/committers-frontend-app-learning. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@itsjeyd itsjeyd added the product review PR requires product review before merging label Oct 11, 2024
@itsjeyd
Copy link

itsjeyd commented Oct 11, 2024

Hi @qasimgulzar, thank you for this contribution!

Since it seems to be a user-facing change it will need to go through product review. You can get that process started by creating a product proposal and pinging #wg-product-core on Slack to find a coordinator (cf. docs).

Based on your latest post on the forum it sounds like openedx/edx-platform#35554 is closely related to this PR. There will be no need to create two separate product proposals, you can make a single one that references both PRs.

CC @mphilbrick211 @openedx/committers-frontend-app-learning

@itsjeyd
Copy link

itsjeyd commented Nov 7, 2024

Hey @qasimgulzar, just checking in to see if you're still planning to continue working on this PR?

As mentioned above, next steps would be to create a combined product proposal for this PR and openedx/edx-platform#35554, and ping #wg-product-core on Slack to find a coordinator for the product review process.

@itsjeyd itsjeyd added the inactive PR author has been unresponsive for several months label Nov 7, 2024
@itsjeyd
Copy link

itsjeyd commented Nov 21, 2024

Hi @qasimgulzar! Just a quick update that I'm closing this PR now because it is stale. You're welcome to reopen this pull request, or open a new one, when you have time to come back to this work.

@itsjeyd itsjeyd closed this Nov 21, 2024
@itsjeyd itsjeyd added closed inactivity PR was closed because the author abandoned it and removed inactive PR author has been unresponsive for several months labels Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed inactivity PR was closed because the author abandoned it open-source-contribution PR author is not from Axim or 2U product review PR requires product review before merging
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants