-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: prompt authentication error message when xblock is not publicly accessible #1492
Conversation
Thanks for the pull request, @qasimgulzar! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Hi @qasimgulzar, thank you for this contribution! Since it seems to be a user-facing change it will need to go through product review. You can get that process started by creating a product proposal and pinging Based on your latest post on the forum it sounds like openedx/edx-platform#35554 is closely related to this PR. There will be no need to create two separate product proposals, you can make a single one that references both PRs. CC @mphilbrick211 @openedx/committers-frontend-app-learning |
Hey @qasimgulzar, just checking in to see if you're still planning to continue working on this PR? As mentioned above, next steps would be to create a combined product proposal for this PR and openedx/edx-platform#35554, and ping |
Hi @qasimgulzar! Just a quick update that I'm closing this PR now because it is stale. You're welcome to reopen this pull request, or open a new one, when you have time to come back to this work. |
Discussion link