-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: trim long text in form controls and username block #899
fix: trim long text in form controls and username block #899
Conversation
Thanks for the pull request, @ihor-romaniuk! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## open-release/quince.master #899 +/- ##
=============================================================
Coverage ? 66.22%
=============================================================
Files ? 52
Lines ? 823
Branches ? 158
=============================================================
Hits ? 545
Misses ? 268
Partials ? 10 ☔ View full report in Codecov by Sentry. |
Hi @openedx/2u-aperture! This is ready for review / merge. Thanks! |
20c9595
into
openedx:open-release/quince.master
@ihor-romaniuk 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Description:
This pull request contains minor fixes that occur when the user has a very long name and there are long choices in form elements.
In these cases, we have the text or element coming out of the sizes of the containers reserved for their display.
Screenshots before:
Screenshots after:
Related Pull Requests:
PR to the open-release/palm.master branch: #887
PR to the master branch: #888