Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent misplaced scrollable shadow when video gallery is loading #405

Closed

Conversation

ArturGaspar
Copy link
Contributor

Description

Prevent ugly shadow when video gallery is loading.

Before: image

After: image

Testing instructions

  1. (Optional) Create a mock videos response with a useful delay
    1. Enable mock video uploads (create waffle flag contentstore.mock_video_uploads enabled for everyone)
    2. Modify videos_index_json() to have a delay so the loading phase can be observed more carefully, as follows:
      def videos_index_json(course):
          """
          ...
          """
          import time
          time.sleep(20)
          # index_videos, __ = _get_index_videos(course)
          index_videos = [{
              'edx_video_id': 'aaaaaaaa-aaaa-4aaa-aaaa-aaaaaaaaaaaa',
              'client_video_id': 'video.mp4',
              'created': '1970-01-01T00:00:00Z',
              'duration': 42.5,
              'status': 'upload',
              'course_video_image_url': 'https://video/images/1234.jpg'
          }]
          return JsonResponse({"videos": index_videos}, status=200)
      
  2. Open video gallery
    1. Enable the new video editor (create waffle flags new_core_editors.use_new_video_editor and new_core_editors.use_video_gallery_flow enabled for everyone)
    2. Create a course unit with a video
    3. Edit the video (should open in new editor)
    4. Click "< Replace video" to go to the gallery
  3. See that the shadow does not appear while the gallery is loading

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 10, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Oct 10, 2023

Thanks for the pull request, @ArturGaspar! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate.

@ArturGaspar ArturGaspar force-pushed the artur/gallery-loading-shadow branch from dfa55aa to 1605e84 Compare October 10, 2023 21:04
@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Oct 10, 2023
@ArturGaspar ArturGaspar marked this pull request as draft October 11, 2023 11:19
@openedx-webhooks
Copy link

@ArturGaspar Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

@e0d e0d removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants