Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): updated frontend-build & frontend-platform major versions #701

Merged
merged 8 commits into from
Jul 5, 2024

Conversation

BilalQamar95
Copy link
Contributor

@BilalQamar95 BilalQamar95 commented Dec 12, 2023

Description

  • Major version upgrades, Updating frontend-build to v14 & frontend-platform to v8 along with respective edx packages
  • Updated jest to v29
  • Updated snapshots for failing tests

@BilalQamar95 BilalQamar95 changed the title chore: bumped frontend-build feat: updated frontend-build & frontend-platform major versions Apr 24, 2024
@BilalQamar95 BilalQamar95 marked this pull request as ready for review May 16, 2024 12:41
@feanil
Copy link

feanil commented Jun 25, 2024

@BilalQamar95 this PR has conflicts, can you update so that it can be reviewed and merged?

Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (2c7345c) to head (9b401c4).

Additional details and impacted files
@@          Coverage Diff           @@
##           master    #701   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files           2       2           
  Lines           7       7           
======================================
  Misses          7       7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

package.json Outdated
@@ -36,7 +36,7 @@
"dependencies": {
"@edx/brand": "npm:@openedx/brand-openedx@^1.2.2",
"@edx/frontend-component-header": "5.3.3",
"@edx/frontend-platform": "7.1.4",
"@edx/frontend-platform": "8.0.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latest version of platform is 8.0.4 - is there a specific reason to keep this pinned to an exact version? It seems just using ^8.0.0 might be a reasonable option here.

@BilalQamar95 BilalQamar95 self-assigned this Jul 4, 2024
@brian-smith-tcril brian-smith-tcril changed the title feat: updated frontend-build & frontend-platform major versions chore(deps): updated frontend-build & frontend-platform major versions Jul 5, 2024
@brian-smith-tcril brian-smith-tcril merged commit 7e15403 into master Jul 5, 2024
6 checks passed
@brian-smith-tcril brian-smith-tcril deleted the bilalqamar95/jest-v29-upgrade branch July 5, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants