Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web OAuth Support #212

Open
Kelketek opened this issue Dec 15, 2023 · 3 comments
Open

Web OAuth Support #212

Kelketek opened this issue Dec 15, 2023 · 3 comments

Comments

@Kelketek
Copy link

Is your feature request related to a problem? Please describe.
Currently, the iOS app allows users to log in with a user account that exists on the LMS, or using a handful of social media sources. However, many instances of the platform use unique authentication providers which would have to be explicitly built under the current methodology.

It is not practical to build a special button for every possible authentication provider. For example, an instance may have SAML configured for their SSO, and may require that all users authenticate to it.

Describe the solution you'd like
The platform already provides a generic method of authenticating to it via OAuth. This is required for the MFEs to work. The actual user authentication may be deferred to an upstream provider, but the platform itself provides an OAuth endpoint handshake that is used for any auxiliary service. The mobile apps can take advantage of this to allow for generic 'web view authentication'.

Using web view authentication is slightly less smooth than having a built-in supported authentication form. However, it is universally functional, and can work with any instance in any authentication configuration without the need for constructing additional UI elements once this feature is implemented.

Describe alternatives you've considered
Building a separate UI/button for each authentication provider is possible but requires each team with their own authentication method to keep track of significant changes and continually rebase them.

Additional context
This change would also be useful for the Android app.

@e0d
Copy link

e0d commented Dec 15, 2023

@marcotuts and @volodymyr-chekyrta can you weigh in on this proposal?

@marcotuts
Copy link

marcotuts commented Dec 9, 2024

This is now merged as a contribution - specifically the option to login via browser instead of natively. thanks @xitij2000 and team!

edit: will mark closed soon given recent merge. fyi @volodymyr-chekyrta

@Kelketek
Copy link
Author

Kelketek commented Dec 9, 2024

@marcotuts It's available for the iOS app as well? I know that we were pushing it for the Android app, but I wasn't aware of it landing here. The last merge for iOS was a month ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants