Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [iOS] On Course "Home" tab the row height changes after a while #483 #486

Closed
wants to merge 2 commits into from

Conversation

forgotvas
Copy link
Contributor

@forgotvas forgotvas commented Jul 9, 2024

[iOS] On Course "Home" tab the row height changes after a while #483

@forgotvas forgotvas changed the base branch from main to develop July 9, 2024 18:00
@forgotvas forgotvas linked an issue Jul 9, 2024 that may be closed by this pull request
@saeedbashir
Copy link
Contributor

saeedbashir commented Jul 10, 2024

@forgotvas Please update the ticket description and mention the correct issue. The issue mentioned in the description is different from the linked issues. And might need to update the PR title as well.

@forgotvas forgotvas changed the title fix: [iOS] Section Level Video Download Progress Visibility fix: [iOS] On Course "Home" tab the row height changes after a while #483 Jul 10, 2024
@forgotvas
Copy link
Contributor Author

@forgotvas Please update the ticket description and mention the correct issue. The issue mentioned in the description is different from the linked issues. And might need to update the PR title as well.

hi @saeedbashir, sorry, my fault, copied from another ticket. Fixed.

Copy link
Contributor

@saeedbashir saeedbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@forgotvas
Copy link
Contributor Author

We're closing this PR and moving these changes to our own fork, as they are critical for us. After our release, we hope to find a way to contribute these changes back, thanks!

@forgotvas forgotvas closed this Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[iOS] On Course "Home" tab the row height changes after a while
3 participants