-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: [FC-0072] migrate project to swift 6 #544
refactor: [FC-0072] migrate project to swift 6 #544
Conversation
Thanks for the pull request, @IvanStepanok! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Course/Course/Presentation/Video/PlayerViewControllerHolder.swift
Outdated
Show resolved
Hide resolved
Discussion/Discussion/Presentation/DiscussionTopics/DiscussionSearchTopicsViewModel.swift
Outdated
Show resolved
Hide resolved
Profile/Profile/Presentation/DatesAndCalendar/DatesAndCalendarViewModel.swift
Outdated
Show resolved
Hide resolved
@rnr Thanks for reviewing! All feedback are addressed |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #544 +/- ##
========================================
Coverage ? 0
========================================
Files ? 0
Lines ? 0
Branches ? 0
========================================
Hits ? 0
Misses ? 0
Partials ? 0 ☔ View full report in Codecov by Sentry. |
This commit updates the entire project to Swift 6, incorporating language features like
Sendable
conformance and improved concurrency support. Key changes include:Sendable
conformance added across the codebase for thread safety.async/await
for modern concurrency handling.BREAKING CHANGE: The project now requires Swift 6, and dependencies or integrations using earlier Swift versions may need adjustments to ensure compatibility.