Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: [FC-0072] migrate project to swift 6 #544

Merged

Conversation

IvanStepanok
Copy link
Contributor

@IvanStepanok IvanStepanok commented Nov 19, 2024

This commit updates the entire project to Swift 6, incorporating language features like Sendable conformance and improved concurrency support. Key changes include:

  • Sendable conformance added across the codebase for thread safety.
  • Extensive migration to async/await for modern concurrency handling.
  • New SwiftGen rule introduced to ensure compatibility with Swift 6.
  • Significant updates to the test suite:
    • Most tests refactored and optimized for reliability and faster execution.
    • Enhanced compatibility with CI/CD pipelines.

BREAKING CHANGE: The project now requires Swift 6, and dependencies or integrations using earlier Swift versions may need adjustments to ensure compatibility.

@openedx-webhooks
Copy link

Thanks for the pull request, @IvanStepanok!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/openedx-mobile-maintainers. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 19, 2024
@mphilbrick211 mphilbrick211 added the FC Relates to an Axim Funded Contribution project label Nov 26, 2024
rnr
rnr previously approved these changes Dec 4, 2024
OpenEdX/Data/DiscoveryPersistence.swift Outdated Show resolved Hide resolved
OpenEdX/Data/DiscoveryPersistence.swift Outdated Show resolved Hide resolved
Core/Core/Network/OfflineSyncManager.swift Outdated Show resolved Hide resolved
Core/Core/Network/OfflineSyncManager.swift Outdated Show resolved Hide resolved
@IvanStepanok
Copy link
Contributor Author

@rnr Thanks for reviewing! All feedback are addressed

@IvanStepanok IvanStepanok requested a review from rnr December 5, 2024 11:35
@volodymyr-chekyrta volodymyr-chekyrta merged commit 55f601c into openedx:develop Dec 5, 2024
7 checks passed
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (develop@331062c). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff            @@
##             develop   #544   +/-   ##
========================================
  Coverage           ?      0           
========================================
  Files              ?      0           
  Lines              ?      0           
  Branches           ?      0           
========================================
  Hits               ?      0           
  Misses             ?      0           
  Partials           ?      0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FC Relates to an Axim Funded Contribution project open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants