feat: [FC-0072] setup linting on ci/cd #549

IvanStepanok · 2024-12-11T11:24:52Z

Integrates SwiftLint more strictly into the project workflow and resolves all existing lint warnings. CI pipeline will now block PRs with SwiftLint warnings to maintain code quality.

Changes

Updated SwiftLint configuration with adjusted rules and limits
Modified CI to reject PRs with SwiftLint warnings
Fixed all existing warnings in codebase

Motivation

Ensures consistent code quality through automated static analysis and enforced coding standards.

Testing

Run SwiftLint locally to verify no warnings
Confirm CI blocks PRs with warnings
Review code changes maintain functionality

openedx-webhooks · 2024-12-11T11:24:57Z

Thanks for the pull request, @IvanStepanok!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
- This process (including the steps you'll need to take) is documented here.
If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

Dependencies

This PR must be merged before / after / at the same time as ...
Blockers

This PR is waiting for OEP-1234 to be accepted.
Timeline information

This PR must be merged by XX date because ...
Partner information

This is for a course on edx.org.
Supporting documentation
Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/openedx-mobile-maintainers. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

The size and impact of the changes that it introduces
The need for product review
Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

github-advanced-security · 2024-12-11T11:38:13Z

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

This reverts commit e3c1566.

volodymyr-chekyrta

LGTM 👍

rnr · 2024-12-11T15:27:04Z

Authorization/Authorization/Presentation/Login/SignInView.swift

+                                                    viewModel.config.ssoButtonTitle[languageCode] as! String,
+                                                    action: {
+                                                        viewModel.router
+                                                            .showSSOWebBrowser(title: CoreLocalization.SignIn.logInBtn)
                                                })


Curly bracket should have own line and indentation

rnr · 2024-12-11T15:29:19Z

Authorization/Authorization/Presentation/Login/SignInView.swift

                                                },
                                                             color: .white,
                                                             textColor: Theme.Colors.accentColor,


fix indentations here please

rnr · 2024-12-11T15:38:05Z

Core/Core/Configuration/Config/DiscoveryConfig.swift

-        get {
-            return type == .webview && webview.baseURL != nil
-        }
+        return type == .webview && webview.baseURL != nil


return is redundant here

rnr · 2024-12-11T15:53:12Z

Core/Core/Data/Model/Data_Media.swift

@@ -38,6 +38,18 @@ public extension DataLayer {
    }
 }

+public extension DataLayer.CourseMedia {
+    var domain: CourseMedia {
+        return CourseMedia(


return is redundant here

rnr · 2024-12-11T16:36:48Z

Course/Course/Presentation/Dates/Elements/StyleBlock.swift

+import Core
+import Theme
+
+struct StyleBlock: View {


Maybe we need to be more specific in naming here - not just StyleBlock, but somehow related to Course Date? WDYT?

rnr · 2024-12-11T16:53:21Z

OpenEdX/DI/ScreenAssembly.swift

+                    connectivity: r.resolve(ConnectivityProtocol.self)!,
+                    playerHolder: holder
+                )
+            })


It looks like the closing bracket should have its own line here

codecov · 2024-12-11T20:45:48Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (develop@17f9376). Learn more about missing BASE report.

Additional details and impacted files

@@           Coverage Diff            @@
##             develop   #549   +/-   ##
========================================
  Coverage           ?      0           
========================================
  Files              ?      0           
  Lines              ?      0           
  Branches           ?      0           
========================================
  Hits               ?      0           
  Misses             ?      0           
  Partials           ?      0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

IvanStepanok · 2024-12-12T11:54:28Z

@rnr Thanks for the review! All feedback has been addressed.

rnr

LGTM! Thank you

IvanStepanok added 2 commits December 9, 2024 17:19

fix: resolve lint warnings

f316b1c

fix: resolve warnings and update swiftlint.yml

d489e1c

openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Dec 11, 2024

fix: update swiftlint

f8e156c

fix: update swiftlint

d43620f

IvanStepanok force-pushed the feat/setup_linting_on_ci branch from 9ac9080 to d43620f Compare December 11, 2024 11:39

IvanStepanok added 4 commits December 11, 2024 13:57

fix: test lint warning

e3c1566

Revert "fix: test lint warning"

dda621e

This reverts commit e3c1566.

fix: update tests

0116538

fix: update swiftlint

fc9dedf

IvanStepanok force-pushed the feat/setup_linting_on_ci branch 3 times, most recently from 48723c6 to 4cbed7c Compare December 11, 2024 13:49

fix: address feedback

a3a9dac

IvanStepanok force-pushed the feat/setup_linting_on_ci branch from 4cbed7c to a3a9dac Compare December 11, 2024 13:50

IvanStepanok changed the title ~~feat: setup linting on ci/cd~~ feat: [FC-0072] setup linting on ci/cd Dec 11, 2024

IvanStepanok requested review from volodymyr-chekyrta and rnr and removed request for volodymyr-chekyrta December 11, 2024 13:54

volodymyr-chekyrta previously approved these changes Dec 11, 2024

View reviewed changes

rnr previously approved these changes Dec 11, 2024

View reviewed changes

mphilbrick211 added the FC Relates to an Axim Funded Contribution project label Dec 11, 2024

fix: address feedback

0d4fdb8

IvanStepanok dismissed stale reviews from rnr and volodymyr-chekyrta via 0d4fdb8 December 12, 2024 11:53

IvanStepanok requested review from rnr and volodymyr-chekyrta December 12, 2024 11:54

rnr approved these changes Dec 12, 2024

View reviewed changes

volodymyr-chekyrta approved these changes Dec 12, 2024

View reviewed changes

volodymyr-chekyrta merged commit c104371 into openedx:develop Dec 12, 2024
8 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: [FC-0072] setup linting on ci/cd #549

feat: [FC-0072] setup linting on ci/cd #549

IvanStepanok commented Dec 11, 2024 •

edited

Loading

openedx-webhooks commented Dec 11, 2024

github-advanced-security bot commented Dec 11, 2024

volodymyr-chekyrta left a comment

rnr Dec 11, 2024

rnr Dec 11, 2024

rnr Dec 11, 2024

rnr Dec 11, 2024

rnr Dec 11, 2024

rnr Dec 11, 2024

codecov bot commented Dec 11, 2024

IvanStepanok commented Dec 12, 2024

rnr left a comment

feat: [FC-0072] setup linting on ci/cd #549

feat: [FC-0072] setup linting on ci/cd #549

Conversation

IvanStepanok commented Dec 11, 2024 • edited Loading

Changes

Motivation

Testing

openedx-webhooks commented Dec 11, 2024

What's next?

🔘 Get product approval

🔘 Provide context

🔘 Get a green build

🔘 Let us know that your PR is ready for review:

Who will review my changes?

Where can I find more information?

When can I expect my changes to be merged?

github-advanced-security bot commented Dec 11, 2024

volodymyr-chekyrta left a comment

Choose a reason for hiding this comment

rnr Dec 11, 2024

Choose a reason for hiding this comment

rnr Dec 11, 2024

Choose a reason for hiding this comment

rnr Dec 11, 2024

Choose a reason for hiding this comment

rnr Dec 11, 2024

Choose a reason for hiding this comment

rnr Dec 11, 2024

Choose a reason for hiding this comment

rnr Dec 11, 2024

Choose a reason for hiding this comment

codecov bot commented Dec 11, 2024

Codecov Report

IvanStepanok commented Dec 12, 2024

rnr left a comment

Choose a reason for hiding this comment

IvanStepanok commented Dec 11, 2024 •

edited

Loading