Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a course-level tag filter to the course comparison dashboard #248

Closed
Tracked by #240
crathbun428 opened this issue Aug 9, 2024 · 6 comments
Closed
Tracked by #240
Assignees

Comments

@crathbun428
Copy link

crathbun428 commented Aug 9, 2024

User Story
As a course delivery team member, I want to be able to compare only courses that have specified course-level tag(s), so that I can compare courses that share something in common (subject matter, competency, etc).

Acceptance Criteria
Given I have access to the Course Comparison dashboard
When I view the Course Comparison dashboard
Then I see that I am able to filter the courses or course runs by Course-level tag(s)
And I am able to search for and select one or more values when applying the filter

And when I apply the filter, I see the course comparison dashboard update to filter and display results including only courses or course runs that match the applied filter (see note for examples and details about course tags).

Notes

  1. If a user selects the Microbiology tag to apply it to a course and the taxonomy used for that instance has a hierarchy in place (example: Biology/Microbiology), both the Biology and Microbiology tags will be applied.
  2. If a user selects multiple course tags (for example 2 course tags) when creating a course tag filter, the results show any result that has tag value 1 OR tag value 2.
  3. If a user wants to compare all courses with the Microbiology tag, they should be comparing all courses with the Microbiology tag regardless of any other tags that may be applied to those courses (for example: courses that are being analyzed may have just Biology/Microbiology applied, some may have the Biology/Microbiology and Biology/Microbiology/Microbiomes tags applied) and that’s OK, both should appear in the results for this filter.
@Ian2012
Copy link
Contributor

Ian2012 commented Aug 28, 2024

The following PRs are in progress for this work:

@Ian2012 Ian2012 self-assigned this Aug 28, 2024
@Ian2012 Ian2012 moved this from Backlog to Blocked in Data Working Group Aug 28, 2024
@Ian2012 Ian2012 moved this from Blocked to Doing in Data Working Group Aug 28, 2024
@saraburns1
Copy link
Contributor

Image

@Ian2012
Copy link
Contributor

Ian2012 commented Sep 3, 2024

@saraburns1 Can you constrain the tags column to at most 32~46 chars? If Superset tables handle that ok, then no problem

@saraburns1
Copy link
Contributor

Hmm from #249 And when there are more than N characters to be shown, we truncate this list (but allow the user some way of viewing the whole list (maybe on hover or clicking to expand/collapse).

I don't know of a way to do this, do you @Ian2012 ? I could truncate it within the sql but there wouldn't be an option to expand it.

@Ian2012
Copy link
Contributor

Ian2012 commented Sep 3, 2024

We are use to truncate those values with SQL, I didn't knew superset allow it to truncate it too. If Superset UI doesn't get unusable on large values I guess we can keep it as you have it right now

@saraburns1
Copy link
Contributor

Going to try it with a scroll bar at the bottom and see what the feedback is

image

@Ian2012 Ian2012 closed this as completed Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

3 participants