Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Superset i18n: Save user's chosen language to user settings #298

Open
pomegranited opened this issue Nov 15, 2024 · 1 comment · May be fixed by openedx/tutor-contrib-aspects#1017
Open
Assignees
Labels
aspects enhancement Relates to new features or improvements to existing features

Comments

@pomegranited
Copy link
Contributor

pomegranited commented Nov 15, 2024

Description

When changing the language settings in Superset, the changes are not saved upon closing and reopening the application. For example, if the default language is English and I change it to Spanish, Superset reverts back to English after restarting. Additionally, if I open Superset in a different browser after setting it to Spanish, it also defaults back to English. This becomes problematic when multiple users are involved. If User 1 prefers Spanish and User 2 prefers English, only one default language can be set, requiring one user to change the language every time they log in. The expected behavior is that once a user changes the language setting, it should persist across sessions.

Supporting Information

Proposed solution

  • Add a new field to the user's Personal Information table which stores the user's preferred language, visible from User Info (/users/userinfo/):
    image
  • Use this setting (or to Superset's default language if no language preference is configured) to set the current language when the user logs in
  • Users can update this setting using the same language dropdown UI element already in Superset.
@pomegranited pomegranited added enhancement Relates to new features or improvements to existing features aspects labels Nov 15, 2024
@pomegranited pomegranited self-assigned this Nov 15, 2024
@pomegranited pomegranited moved this to Ready for Work in Data Working Group Nov 15, 2024
@bmtcril
Copy link
Contributor

bmtcril commented Nov 15, 2024

Just noting that this is an upstream Superset enhancement, but is an improvement we want for Aspects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aspects enhancement Relates to new features or improvements to existing features
Projects
Status: Ready for Work
Development

Successfully merging a pull request may close this issue.

2 participants